Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Offset, Direction, and Split Probability Support to PottsLocation Split Method #16

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Add Offset, Direction, and Split Probability Support to PottsLocation Split Method #16

wants to merge 20 commits into from

Conversation

Jannetty
Copy link
Member

@Jannetty Jannetty commented Sep 18, 2024 •
edited
Loading

  • Overloaded split so providing a three-integer percent offset moves split location from location center to location specified by offset
  • Implemented getSplitPoint function that finds splitpoint given offsets
  • Overloaded split so a split direction can be specified
  • Added boolean that specifies whether voxel lists returned from split should be balanced and connected. Only balances and connects when offset and direction are not specified
  • Overloaded split so a probability of returning one voxel list vs another can be specified
  • Wrote override for getSplitpoint in PottsLocation2D that adds a 0 for the z offset
  • Wrote and amended tests

@Jannetty Jannetty changed the base branch from main to develop September 18, 2024 16:40
@Jannetty Jannetty changed the title Add support for 3-integer percent offsets in PottsLocation split method to customize split location Add support for percent offsets and direction in PottsLocation split method to customize split location/direction Sep 19, 2024
@Jannetty Jannetty marked this pull request as draft September 19, 2024 18:46
@Jannetty Jannetty marked this pull request as ready for review September 19, 2024 22:47
@Jannetty Jannetty changed the title Add support for percent offsets and direction in PottsLocation split method to customize split location/direction Add Offset, Direction, and Split Probability Support to PottsLocation Split Method Sep 19, 2024
@Jannetty Jannetty marked this pull request as draft September 24, 2024 18:13
@Jannetty Jannetty marked this pull request as ready for review September 24, 2024 22:21
Jannetty and others added 20 commits September 24, 2024 21:00
@Jannetty
added functionality so offset can be provided to split
1444db6
@Jannetty
formatting fixes
3ab4387
@Jannetty
removed unnecessary import
d96f535
@Jannetty
removed unnecessary comment
2f06999
@Jannetty
formatting fixes:
2088c3f
@Jannetty
adding in tabs
aa3569d
@Jannetty
added ability to specify direction as well as offest in PottsLocation…
c8a9941 
… split
@Jannetty
only call connect_voxels if splitpoint is not specified to split func…
08a46da 
…tion in PottsLocation
@Jannetty
formatting fixes
2bceb50
@Jannetty
further formatting fix
b36b652
@Jannetty
adding ability to specify probability split returns voxelsA vs voxelsB
7a385ff
@Jannetty
added tests
87e20bc
@Jannetty
fixed broken test
0722827
@Jannetty
formatting
5f4f47a
@Jannetty
renamed splitProbability
453e033
@Jannetty
fixed accidental changing of cell offsetPercents field
4fd807b
@Jannetty
deleting print statement I accidentally left in
e9340f7
@jessicasyu @Jannetty
Streamline method overloading and unit tests
77fcaa6
@jessicasyu @Jannetty
Fix javadoc spacing
5de8f5c
@Jannetty
added split test using zx direction to test split functionality in z …
65c98d1 
…plane
@Jannetty Jannetty force-pushed the jannetty/overload-PottsLocation-getCenter branch from 1ec7a16 to 65c98d1 Compare September 25, 2024 04:02
@Jannetty
Copy link
Member Author

The force push above was me rebasing to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicasyu jessicasyu Awaiting requested review from jessicasyu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jannetty @jessicasyu