Update substrate term parameters

bagherilab · Jun 6, 2023 · 4f8ed6e · 4f8ed6e
1 parent a7a3417
commit 4f8ed6e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/src/arcade/potts/parameter.potts.xml b/src/arcade/potts/parameter.potts.xml
@@ -28,7 +28,7 @@
 
     <!-- substrate term parameters -->
     <potts.term term="substrate" id="HEIGHT_THRESHOLD" value="9" units="um" conversion="DS^-1" />
-    <potts.term term="substrate" id="ADHESION" value="2" />
+    <potts.term term="substrate" id="ADHESION" value="5" />
 
     <!-- persistence term parameters -->
     <potts.term term="persistence" id="LAMBDA" value="0.01" conversion="DS^-2" />

diff --git a/src/arcade/potts/sim/hamiltonian/SubstrateHamiltonian.java b/src/arcade/potts/sim/hamiltonian/SubstrateHamiltonian.java
@@ -17,7 +17,7 @@ public class SubstrateHamiltonian implements Hamiltonian {
     static final int NUMBER_NEIGHBORS = 9;
 
     /** Scaling at threshold height. */
-    static final double THRESHOLD_FRACTION = 0.001;
+    static final double THRESHOLD_FRACTION = 0.01;
 
     /** Map of hamiltonian config objects. */
     final HashMap<Integer, SubstrateHamiltonianConfig> configs;
@@ -62,9 +62,9 @@ public void deregister(PottsCell cell) {
     /**
      * {@inheritDoc}
      * <p>
-     * Substrate energy is calculated by summing across substrate voxels
-     * bordering the given voxel. Change in adhesion energy is taken as the
-     * difference in substrate energies for the source and target IDs.
+     * Substrate energy is calculated by summing across substrate voxels below
+     * the given voxel. Change in adhesion energy is taken as the difference in
+     * substrate energies for the source and target IDs.
      */
     @Override
     public double getDelta(int sourceID, int targetID, int x, int y, int z) {
@@ -87,9 +87,9 @@ public double getDelta(int id, int sourceRegion, int targetRegion, int x, int y,
     /**
      * Gets substrate energy for a given voxel.
      * <p>
-     * Substrate is assumed to be located at z = 0. Media (id = 0) and cells not
-     * located adjacent to z = 0 (i.e. z == 1) return zero for substrate
-     * energy.
+     * Substrate is assumed to be located at z = 0. Media (id = 0) returns zero
+     * for substrate energy. Substrate energy is scaled by distance from z = 0
+     * by a power function.
      *
      * @param id  the voxel id
      * @param x  the x coordinate
@@ -102,18 +102,17 @@ public double getDelta(int id, int sourceRegion, int targetRegion, int x, int y,
             return 0;
         }
 
-        SubstrateHamiltonianConfig config = configs.get(id);
+        double substrate = configs.get(id).getSubstrate();
+        double substrateEnergy = 0;
 
-        double s = 0;
         for (int i = x - 1; i <= x + 1; i++) {
             for (int j = y - 1; j <= y + 1; j++) {
-                s += -substrates[i][j] * config.getSubstrate();
+                substrateEnergy -= substrates[i][j];
             }
         }
 
-        s = Math.pow(z, power) * s / NUMBER_NEIGHBORS;
-
-        return s;
+        substrateEnergy = Math.pow(z, power) * substrateEnergy / NUMBER_NEIGHBORS * substrate;
+        return substrateEnergy;
     }
 
     /**