Skip to content

made abstract PottsCellFlyStem class with subclasses for each cell ty… #167

made abstract PottsCellFlyStem class with subclasses for each cell ty…

made abstract PottsCellFlyStem class with subclasses for each cell ty… #167

Triggered via push August 30, 2024 20:19
Status Success
Total duration 40s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

271 errors and 2 warnings
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L296 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L296
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'splitHalvesHorizontallyReturnBasalHalf' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'splitHalvesHorizontallyReturnBasalHalf' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L316 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L316
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'splitHalvesVerticallyReturnRandomHalf' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'splitHalvesVerticallyReturnRandomHalf' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L340 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L340
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'splitHalvesVerticallyReturnLeftHalf' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'splitHalvesVerticallyReturnLeftHalf' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L361 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L361
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'splitTwoThirdsOneThirdKeepTopTwoThirds' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'splitTwoThirdsOneThirdKeepTopTwoThirds' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L380 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L380
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'getTopTwoThirds' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'getTopTwoThirds' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L408 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L408
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'getTopOneThird' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'getTopOneThird' static/final/abstract/empty, or adding allowed annotation for the method.
[checkstyle] src/arcade/potts/env/location/PottsLocation.java#L436 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>: src/arcade/potts/env/location/PottsLocation.java#L436
Class 'PottsLocation' looks like designed for extension (can be subclassed), but the method 'splitOneThirdTwoThirdsKeepBottomTwoThirds' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsLocation' final or making the method 'splitOneThirdTwoThirdsKeepBottomTwoThirds' static/final/abstract/empty, or adding allowed annotation for the method.
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/