Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurency configuration option for keycloak backend #2121

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 2, 2024

Hey, I just made a Pull Request!

What does this pr fix:

janus-idp/backstage-plugins#2471
https://issues.redhat.com/browse/RHIDP-4793

Demo:

https://youtu.be/miQ9DgaOYcg

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the add-concurency-configuration-option-for-keycloak-backend branch from 8f1ebba to fe81244 Compare December 2, 2024 13:27
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 2, 2024

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage-community/plugin-catalog-backend-module-keycloak

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-catalog-backend-module-keycloak workspaces/keycloak/plugins/catalog-backend-module-keycloak none v3.2.4

@AndrienkoAleksandr AndrienkoAleksandr force-pushed the add-concurency-configuration-option-for-keycloak-backend branch from fe81244 to 3324173 Compare December 2, 2024 13:35
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the add-concurency-configuration-option-for-keycloak-backend branch from cf15bc2 to 58ac3c8 Compare December 9, 2024 12:14
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the add-concurency-configuration-option-for-keycloak-backend branch from 5d45e7a to 68ab0a4 Compare December 19, 2024 11:44
JohannesWill and others added 20 commits December 23, 2024 10:40
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the add-concurency-configuration-option-for-keycloak-backend branch from 4f44a5c to 525aad8 Compare December 23, 2024 08:48
@AndrienkoAleksandr AndrienkoAleksandr marked this pull request as ready for review December 23, 2024 12:11
@dzemanov
Copy link
Contributor

@AndrienkoAleksandr Can you please generate changeset when you will have time?

@dzemanov
Copy link
Contributor

Tested with 1000 groups and 500000 users, works as expected.
Interestingly, each scheduled run more users are commited, e.g:

Committed 27173 Keycloak users and 1000 Keycloak groups
...
Committed 31119 Keycloak users and 1000 Keycloak groups
...
Committed 42271 Keycloak users and 1000 Keycloak groups
...
Committed 43885 Keycloak users and 1000 Keycloak groups
...
Committed 44735 Keycloak users and 1000 Keycloak groups
...

So it will take more scheduled runs to commit all users in Keycloak.

Tested also locally as dynamic plugin in backstage-showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants