fix(keycloak): serialize the calls to get groups and users #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
PatAKnight
force-pushed
the
keycloak-fix
branch
2 times, most recently
from
23e94e6 to
872eb90
Compare
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
PatAKnight
force-pushed
the
keycloak-fix
branch
from
22320f8 to
565b554
Compare
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
vinzscam
reviewed
Dec 3, 2024
| max: entityQuerySize, | ||
| first: i * entityQuerySize, | ||
| }); | ||
| entityResults.push(...entitiesPage); |
There was a problem hiding this comment.
so that we avoid a possible stack overflow 😅
Suggested change
| entityResults.push(...entitiesPage); | |
| entityResults.concat(entitiesPage); |
|
Closing in favor of #2121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Serialize the calls to get groups and users from Keycloak. In cases where there was a large number of users and / or groups, originally the keycloak plugin would make many async calls that would lead to DOS of the keycloak server.
✔️ Checklist
Signed-off-byline in the message. (more info)