Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of places we forget to aws_raise_error() #350

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix a bunch of places we forget to aws_raise_error() #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef7569d
Fix a bunch of places we forget to aws_raise_error()
graebm Feb 9, 2024
efdfc17
BUILDER_VERSION: v0.9.55
graebm Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- 'main'

env:
BUILDER_VERSION: v0.9.43
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-mqtt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:

env:
BUILDER_VERSION: v0.9.29
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-mqtt
Expand Down
2 changes: 1 addition & 1 deletion codebuild/mqtt-canary-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ env:
CANARY_CLIENT_COUNT: 10
CANARY_LOG_FILE: 'canary_log.txt'
CANARY_LOG_LEVEL: 'ERROR'
BUILDER_VERSION: v0.9.40
BUILDER_VERSION: v0.9.55
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: 'aws-c-mqtt'
Expand Down
2 changes: 1 addition & 1 deletion source/client_channel_handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ static int s_process_read_message(
struct aws_mqtt_client_connection_311_impl *connection = handler->impl;

if (message->message_type != AWS_IO_MESSAGE_APPLICATION_DATA || message->message_data.len < 1) {
return AWS_OP_ERR;
return aws_raise_error(AWS_ERROR_INVALID_STATE);
}

AWS_LOGF_TRACE(
Expand Down
2 changes: 1 addition & 1 deletion source/mqtt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ static int aws_mqtt_utf8_decoder(uint32_t codepoint, void *user_data) {
return aws_raise_error(AWS_ERROR_MQTT5_INVALID_UTF8_STRING);
}

return AWS_ERROR_SUCCESS;
return AWS_OP_SUCCESS;
}

static struct aws_utf8_decoder_options s_aws_mqtt_utf8_decoder_options = {
Expand Down
2 changes: 1 addition & 1 deletion source/v5/mqtt5_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,7 +1591,7 @@ static int s_process_read_message(

if (message->message_type != AWS_IO_MESSAGE_APPLICATION_DATA) {
AWS_LOGF_ERROR(AWS_LS_MQTT5_CLIENT, "id=%p: unexpected io message data", (void *)client);
return AWS_OP_ERR;
return aws_raise_error(AWS_ERROR_INVALID_STATE);
}

AWS_LOGF_TRACE(
Expand Down
2 changes: 1 addition & 1 deletion source/v5/mqtt5_topic_alias.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ int aws_mqtt5_outbound_topic_alias_resolver_reset(
uint16_t topic_alias_maximum) {

if (resolver == NULL) {
return AWS_OP_ERR;
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}

return (*resolver->vtable->reset_fn)(resolver, topic_alias_maximum);
Expand Down
Loading