Drop dependency on jaxb for converting binary arrays to hex #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esirkova
commented
Aug 24, 2023
| return INSTANCE.convertToHex(data); | ||
| } | ||
|
|
||
| private String convertToHex(byte[] data) { |
There was a problem hiding this comment.
The implementation here is the same as in the original jaxb DatatypeConverter.printHexBinary.
VeeramaniBagavathi
approved these changes
Aug 25, 2023
meetidnani
approved these changes
Aug 25, 2023
vsadokhin
approved these changes
Aug 29, 2023
lc-nyovchev
approved these changes
Aug 31, 2023
|
Can some of the maintainers of the library also have a look at this PR? |
|
Thanks, @esirkova! What's the current status on this? We are upgrading to Java 17/JakartaEE and this is a blocker for us. |
aakkem
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This is related to #452 and would remove the need for #522.
Description of changes:
The jaxb depedency (
javax.xml.bind) is used in a couple of classes to convert a binary array to a hex string. As suggested in #452 (comment) it is possible to drop the dependency and just have a simple converter instead. This will also remove the need to care about potentialjakartanamespace switch in the future. This is important because currently trying to use the kinesis-producer library together with Spring 6 + latest Spring JPA/Hibernate results in errors. Removing the jaxb dependency from the kinesis-producer library fixes this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.