Remove Guava dependency, use CompletableFuture #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esirkova
approved these changes
Sep 19, 2023
lc-nyovchev
approved these changes
Sep 20, 2023
|
Looks like this has a couple of approvals, what is preventing a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A proposal to use
CompletableFutureinstead ofListenableFuture.Currently the KPL uses
ListenableFuture, which was introduced by Guava prior to Java 8's release ofCompletableFuture. Since the build for the KPL targets Java 8, it didn't seem to make much sense to continue to use Guava here. Much of the ecosystem has built abstractions and libraries aroundCompletableFutureuse, so it makes sense for the KPL to follow that lead.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.