test(toolkit): Add region provider remote test

packages/core/src/shared/regions/regionProvider.ts

@@ -162,13 +162,20 @@ export class RegionProvider {
         remote: () => Endpoints | Promise<Endpoints>
     }): RegionProvider {
         const instance = new this()
+        void instance.init(endpointsProvider)
+        return instance
+    }
 
-        async function load() {
+    async init(endpointsProvider: {
+        local: () => Endpoints | Promise<Endpoints>
+        remote: () => Endpoints | Promise<Endpoints>
+    }) {
+        const load = async () => {
             getLogger().info('endpoints: retrieving AWS endpoints data')
-            instance.loadFromEndpoints(await endpointsProvider.local())
+            this.loadFromEndpoints(await endpointsProvider.local())
 
             try {
-                instance.loadFromEndpoints(await endpointsProvider.remote())
+                this.loadFromEndpoints(await endpointsProvider.remote())
             } catch (err) {
                 getLogger().warn(
                     `endpoints: failed to load from remote source, region data may appear outdated: %s`,
@@ -177,7 +184,7 @@ export class RegionProvider {
             }
         }
 
-        load().catch((err) => {
+        return load().catch((err) => {
             getLogger().error('Failure while loading Endpoints Manifest: %s', err)
 
             return vscode.window.showErrorMessage(
@@ -191,8 +198,6 @@ export class RegionProvider {
                 )}`
             )
         })
-
-        return instance
     }
 }
 

packages/core/src/testInteg/regionProvider.test.ts

@@ -0,0 +1,46 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import assert from 'assert'
+import { makeEndpointsProvider } from '../extension'
+import { RegionProvider } from '../shared/regions/regionProvider'
+import globals from '../shared/extensionGlobals'
+import { makeTemporaryToolkitFolder } from '../shared/filesystemUtilities'
+import { fs } from '../shared/fs/fs'
+import path from 'path'
+
+describe('Region Provider', async function () {
+    let tempDir: string
+
+    before(async () => {
+        tempDir = await makeTemporaryToolkitFolder()
+    })
+
+    after(async () => {
+        await fs.delete(tempDir, {
+            recursive: true,
+            force: true,
+        })
+    })
+
+    it('resolves from remote', async function () {
+        /**
+         * Make sure the local file doesn't resolve to any endpoints.
+         * That way we can make sure remote contents are fetched
+         */
+        const filePath = path.join(tempDir, 'foo.json')
+        await fs.writeFile(filePath, '{}')
+        globals.manifestPaths.endpoints = filePath
+
+        await assert.doesNotReject(async () => {
+            const endpointProvider = makeEndpointsProvider()
+            const regionProvider = new RegionProvider()
+            await regionProvider.init(endpointProvider)
+
+            // regions loaded from the remote
+            assert.ok(regionProvider.getRegions().length > 0)
+        })
+    })
+})