test(toolkit): Add region provider remote test #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| async function load() { | ||
| async init(endpointsProvider: { |
There was a problem hiding this comment.
Should we switch this to a try/catch at this point, dropping the const load
There was a problem hiding this comment.
just played around with this. let me know what you think
| }) | ||
| }) | ||
|
|
||
| it('resolves from remote', async function () { |
There was a problem hiding this comment.
nice and simple test 🎉
justinmk3
approved these changes
Jan 24, 2025
jpinkney-aws
force-pushed
the
resolve-endpoints
branch
from
0f3d4e3 to
9b14b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the release yesterday we found an issue where fetching remote region data was failing
Solution
Add a new test since its critical to the flow
feature/xbranches will not be squash-merged at release time.