fix warnings

src/aws-cpp-sdk-core/include/aws/core/AmazonSerializableWebServiceRequest.h

@@ -39,7 +39,7 @@ namespace Aws
             AWS_UNREFERENCED_PARAM(AMZN_XML_CONTENT_TYPE);
         }
 
-        virtual ~AmazonSerializableWebServiceRequest() {}
+        virtual ~AmazonSerializableWebServiceRequest() override{}
 
         /**
          * Convert payload into String.

src/aws-cpp-sdk-core/include/aws/core/AmazonStreamingWebServiceRequest.h

@@ -32,7 +32,7 @@ namespace Aws
         {
         }
 
-        virtual ~AmazonStreamingWebServiceRequest();
+        virtual ~AmazonStreamingWebServiceRequest() override;
 
         /**
          * Get the user set stream
@@ -72,7 +72,7 @@ namespace Aws
         /**
          * Override this method to put data members from a subclass into the headers collection.
          */
-        virtual Aws::Http::HeaderValueCollection GetRequestSpecificHeaders() const { return Aws::Http::HeaderValueCollection(); };
+        virtual Aws::Http::HeaderValueCollection GetRequestSpecificHeaders() const { return Aws::Http::HeaderValueCollection(); }
 
     private:
         std::shared_ptr<Aws::IOStream> m_bodyStream;

src/aws-cpp-sdk-core/include/aws/core/AmazonWebServiceRequest.h

@@ -180,9 +180,9 @@ namespace Aws
 
         virtual const char* GetServiceRequestName() const = 0;
 
-        inline virtual void SetServiceSpecificParameters(const std::shared_ptr<Http::ServiceSpecificParameters>& serviceSpecificParameters) const { m_serviceSpecificParameters = serviceSpecificParameters; };
+        inline virtual void SetServiceSpecificParameters(const std::shared_ptr<Http::ServiceSpecificParameters>& serviceSpecificParameters) const { m_serviceSpecificParameters = serviceSpecificParameters; }
 
-        inline virtual std::shared_ptr<Http::ServiceSpecificParameters> GetServiceSpecificParameters() const { return m_serviceSpecificParameters; };
+        inline virtual std::shared_ptr<Http::ServiceSpecificParameters> GetServiceSpecificParameters() const { return m_serviceSpecificParameters; }
 
         using EndpointParameters = Aws::Vector<Aws::Endpoint::EndpointParameter>;
         virtual EndpointParameters GetEndpointContextParams() const;

src/aws-cpp-sdk-core/include/aws/core/auth/bearer-token-provider/DefaultBearerTokenProviderChain.h

@@ -21,7 +21,7 @@ namespace Aws
         {
         public:
             DefaultBearerTokenProviderChain();
-            virtual ~DefaultBearerTokenProviderChain() = default;
+            virtual ~DefaultBearerTokenProviderChain() override = default;
 
             /**
              * Return bearer token, implementation of a base class interface

src/aws-cpp-sdk-core/include/aws/core/auth/signer/AWSAuthBearerSigner.h

@@ -42,7 +42,7 @@ namespace Aws
               : m_bearerTokenProvider(bearerTokenProvider)
             {}
 
-            virtual ~AWSAuthBearerSigner() {};
+            virtual ~AWSAuthBearerSigner() override {}
 
             /**
              * Return the signer's name

src/aws-cpp-sdk-core/include/aws/core/auth/signer/AWSAuthV4Signer.h

@@ -83,7 +83,7 @@ namespace Aws
                             const char* serviceName, const Aws::String& region, PayloadSigningPolicy signingPolicy = PayloadSigningPolicy::RequestDependent,
                             bool urlEscapePath = true, Aws::Auth::AWSSigningAlgorithm signingAlgorithm = Aws::Auth::AWSSigningAlgorithm::SIGV4);
 
-            virtual ~AWSAuthV4Signer();
+            virtual ~AWSAuthV4Signer() override;
 
             /**
              * AWSAuthV4signer's implementation of virtual function from base class

src/aws-cpp-sdk-core/include/aws/core/client/AWSClient.h

@@ -94,7 +94,7 @@ namespace Aws
                       const std::shared_ptr<Aws::Auth::AWSAuthSignerProvider>& signerProvider,
                       const std::shared_ptr<AWSErrorMarshaller>& errorMarshaller);
 
-            virtual ~AWSClient() { };
+            virtual ~AWSClient() { }
 
             /**
              * Generates a signed Uri using the injected signer. for the supplied uri and http method. expirationInSeconds defaults

src/aws-cpp-sdk-core/include/aws/core/client/AWSJsonClient.h

@@ -46,7 +46,7 @@ namespace Aws
                     const std::shared_ptr<Aws::Auth::AWSAuthSignerProvider>& signerProvider,
                     const std::shared_ptr<AWSErrorMarshaller>& errorMarshaller);
 
-            virtual ~AWSJsonClient() = default;
+            virtual ~AWSJsonClient() override = default;
 
         protected:
             /**

src/aws-cpp-sdk-core/include/aws/core/client/AWSUrlPresigner.h

@@ -25,7 +25,7 @@ namespace Aws
         public:
             AWSUrlPresigner(const AWSClient& client);
 
-            virtual ~AWSUrlPresigner() {};
+            virtual ~AWSUrlPresigner() {}
 
             /**
              * Generates a signed Uri using the injected signer, for the supplied uri and http method. expirationInSeconds defaults

src/aws-cpp-sdk-core/include/aws/core/client/AWSXmlClient.h

@@ -41,7 +41,7 @@ namespace Aws
                 const std::shared_ptr<Aws::Auth::AWSAuthSignerProvider>& signerProvider,
                 const std::shared_ptr<AWSErrorMarshaller>& errorMarshaller);
 
-            virtual ~AWSXMLClient() = default;
+            virtual ~AWSXMLClient() override = default;
 
         protected:
             /**

src/aws-cpp-sdk-core/include/aws/core/client/RetryStrategy.h

@@ -106,7 +106,7 @@ namespace Aws
         {
         public:
             DefaultRetryQuotaContainer();
-            virtual ~DefaultRetryQuotaContainer() = default;
+            virtual ~DefaultRetryQuotaContainer() override = default;
             virtual bool AcquireRetryQuota(int capacityAmount) override;
             virtual bool AcquireRetryQuota(const AWSError<CoreErrors>& error) override;
             virtual void ReleaseRetryQuota(int capacityAmount) override;

src/aws-cpp-sdk-core/include/aws/core/config/AWSConfigFileProfileConfigLoader.h

@@ -26,7 +26,7 @@ namespace Aws
              */
             AWSConfigFileProfileConfigLoader(const Aws::String& fileName, bool useProfilePrefix = false);
 
-            virtual ~AWSConfigFileProfileConfigLoader() = default;
+            virtual ~AWSConfigFileProfileConfigLoader() override= default;
 
             /**
              * File path being used for the config loader.

src/aws-cpp-sdk-core/include/aws/core/config/AWSProfileConfigLoaderBase.h

@@ -37,7 +37,7 @@ namespace Aws
             /**
              * Gets all profiles from the configuration file.
              */
-            inline const Aws::Map<Aws::String, Aws::Config::Profile> &GetProfiles() const { return m_profiles; };
+            inline const Aws::Map<Aws::String, Aws::Config::Profile> &GetProfiles() const { return m_profiles; }
 
             /**
              * the timestamp from the last time the profile information was loaded from file.

src/aws-cpp-sdk-core/include/aws/core/config/EC2InstanceProfileConfigLoader.h

@@ -34,7 +34,7 @@ namespace Aws
              */
             EC2InstanceProfileConfigLoader(const std::shared_ptr<Aws::Internal::EC2MetadataClient>& = nullptr);
 
-            virtual ~EC2InstanceProfileConfigLoader() = default;
+            virtual ~EC2InstanceProfileConfigLoader() override = default;
 
         protected:
             virtual bool LoadInternal() override;

src/aws-cpp-sdk-core/include/aws/core/endpoint/AWSEndpoint.h

@@ -32,7 +32,7 @@ namespace Aws
             using EndpointAttributes = Internal::Endpoint::EndpointAttributes;
 
             virtual ~AWSEndpoint()
-            {};
+            {}
 
             Aws::String GetURL() const;
             void SetURL(Aws::String url);

src/aws-cpp-sdk-core/include/aws/core/endpoint/internal/AWSEndpointAttribute.h

@@ -18,7 +18,7 @@ namespace Aws
             class AWS_CORE_API EndpointAuthScheme
             {
             public:
-                virtual ~EndpointAuthScheme(){};
+                virtual ~EndpointAuthScheme(){}
 
                 inline const Aws::String& GetName() const
                 {

src/aws-cpp-sdk-core/include/aws/core/http/HttpResponse.h

@@ -126,6 +126,70 @@ namespace Aws
                 case HttpResponseCode::NETWORK_READ_TIMEOUT:
                 case HttpResponseCode::NETWORK_CONNECT_TIMEOUT:
                     return true;
+                case HttpResponseCode::REQUEST_NOT_MADE:
+                case HttpResponseCode::CONTINUE:
+                case HttpResponseCode::SWITCHING_PROTOCOLS:
+                case HttpResponseCode::PROCESSING:
+                case HttpResponseCode::OK:
+                case HttpResponseCode::CREATED:
+                case HttpResponseCode::ACCEPTED:
+                case HttpResponseCode::NON_AUTHORITATIVE_INFORMATION:
+                case HttpResponseCode::NO_CONTENT:
+                case HttpResponseCode::RESET_CONTENT:
+                case HttpResponseCode::PARTIAL_CONTENT:
+                case HttpResponseCode::MULTI_STATUS:
+                case HttpResponseCode::ALREADY_REPORTED:
+                case HttpResponseCode::IM_USED:
+                case HttpResponseCode::MULTIPLE_CHOICES:
+                case HttpResponseCode::MOVED_PERMANENTLY:
+                case HttpResponseCode::FOUND:
+                case HttpResponseCode::SEE_OTHER:
+                case HttpResponseCode::NOT_MODIFIED:
+                case HttpResponseCode::USE_PROXY:
+                case HttpResponseCode::SWITCH_PROXY:
+                case HttpResponseCode::TEMPORARY_REDIRECT:
+                case HttpResponseCode::PERMANENT_REDIRECT:
+                case HttpResponseCode::BAD_REQUEST:
+                case HttpResponseCode::UNAUTHORIZED:
+                case HttpResponseCode::PAYMENT_REQUIRED:
+                case HttpResponseCode::FORBIDDEN:
+                case HttpResponseCode::NOT_FOUND:
+                case HttpResponseCode::METHOD_NOT_ALLOWED:
+                case HttpResponseCode::NOT_ACCEPTABLE:
+                case HttpResponseCode::PROXY_AUTHENTICATION_REQUIRED:
+                case HttpResponseCode::CONFLICT:
+                case HttpResponseCode::GONE:
+                case HttpResponseCode::LENGTH_REQUIRED:
+                case HttpResponseCode::PRECONDITION_FAILED:
+                case HttpResponseCode::REQUEST_ENTITY_TOO_LARGE:
+                case HttpResponseCode::REQUEST_URI_TOO_LONG:
+                case HttpResponseCode::UNSUPPORTED_MEDIA_TYPE:
+                case HttpResponseCode::REQUESTED_RANGE_NOT_SATISFIABLE:
+                case HttpResponseCode::EXPECTATION_FAILED:
+                case HttpResponseCode::IM_A_TEAPOT:
+                case HttpResponseCode::METHOD_FAILURE:
+                case HttpResponseCode::UNPROC_ENTITY:
+                case HttpResponseCode::LOCKED:
+                case HttpResponseCode::FAILED_DEPENDENCY:
+                case HttpResponseCode::UPGRADE_REQUIRED:
+                case HttpResponseCode::PRECONDITION_REQUIRED:
+                case HttpResponseCode::REQUEST_HEADER_FIELDS_TOO_LARGE:
+                case HttpResponseCode::NO_RESPONSE:
+                case HttpResponseCode::RETRY_WITH:
+                case HttpResponseCode::BLOCKED:
+                case HttpResponseCode::REDIRECT:
+                case HttpResponseCode::REQUEST_HEADER_TOO_LARGE:
+                case HttpResponseCode::CERT_ERROR:
+                case HttpResponseCode::NO_CERT:
+                case HttpResponseCode::HTTP_TO_HTTPS:
+                case HttpResponseCode::CLIENT_CLOSED_TO_REQUEST:
+                case HttpResponseCode::NOT_IMPLEMENTED:
+                case HttpResponseCode::HTTP_VERSION_NOT_SUPPORTED:
+                case HttpResponseCode::VARIANT_ALSO_NEGOTIATES:
+                case HttpResponseCode::INSUFFICIENT_STORAGE:
+                case HttpResponseCode::LOOP_DETECTED:
+                case HttpResponseCode::NOT_EXTENDED:
+                case HttpResponseCode::NETWORK_AUTHENTICATION_REQUIRED:
                 default:
                     return false;
             }
@@ -203,7 +267,7 @@ namespace Aws
               * It isn't pure virtual for backwards compatiblity reasons, but the StandardHttpResponse used by default in the SDK
               * implements the move.
               */
-            virtual void AddHeader(const Aws::String& headerName, Aws::String&& headerValue) { AddHeader(headerName, headerValue); };
+            virtual void AddHeader(const Aws::String& headerName, Aws::String&& headerValue) { AddHeader(headerName, headerValue); }
             /**
              * Sets the content type header on the http response object.
              */

src/aws-cpp-sdk-core/include/aws/core/utils/crypto/HMAC.h

@@ -25,8 +25,8 @@ namespace Aws
             class AWS_CORE_API HMAC
             {
             public:
-                HMAC() {};
-                virtual ~HMAC() {};
+                HMAC() {}
+                virtual ~HMAC() {}
 
                 /**
                 * Calculates an HMAC digest

src/aws-cpp-sdk-core/include/aws/core/utils/crypto/Sha256.h

@@ -42,7 +42,7 @@ namespace Aws
                  * Initializes platform crypto libs.
                  */
                 Sha256();
-                virtual ~Sha256();
+                virtual ~Sha256() override;
 
                 /**
                 * Calculates a SHA256 Hash digest (not hex encoded)

src/aws-cpp-sdk-core/include/aws/core/utils/crypto/Sha256HMAC.h

@@ -41,7 +41,7 @@ namespace Aws
                  * initializes platform specific libs.
                  */
                 Sha256HMAC();
-                virtual ~Sha256HMAC();
+                virtual ~Sha256HMAC() override;
 
                 /**
                 * Calculates a SHA256 HMAC digest (not hex encoded)

src/aws-cpp-sdk-core/include/aws/core/utils/event/EventHeader.h

@@ -57,7 +57,7 @@ namespace Aws
                         m_eventHeaderStaticValue.boolValue = aws_event_stream_header_value_as_bool(header) != 0;
                         break;
                     case EventHeaderType::BYTE:
-                        m_eventHeaderStaticValue.byteValue = aws_event_stream_header_value_as_byte(header);
+                        m_eventHeaderStaticValue.byteValue = static_cast<uint8_t>(aws_event_stream_header_value_as_byte(header));
                         break;
                     case EventHeaderType::INT16:
                         m_eventHeaderStaticValue.int16Value = aws_event_stream_header_value_as_int16(header);
@@ -81,11 +81,12 @@ namespace Aws
                         assert(header->header_value_len == 16u);
                         m_eventHeaderVariableLengthValue = ByteBuffer(static_cast<uint8_t*>(aws_event_stream_header_value_as_uuid(header).buffer), header->header_value_len);
                         break;
+                    case EventHeaderType::UNKNOWN:
                     default:
                         AWS_LOG_ERROR(CLASS_TAG, "Encountered unknown type of header.");
                         break;
                     }
-                };
+                }
 
                 EventHeaderValue(const Aws::String& s) :
                     m_eventHeaderType(EventHeaderType::STRING),

src/aws-cpp-sdk-core/include/aws/core/utils/logging/DefaultCRTLogSystem.h

@@ -24,7 +24,7 @@ namespace Aws
             {
             public:
                 DefaultCRTLogSystem(LogLevel logLevel);
-                virtual ~DefaultCRTLogSystem() = default;
+                virtual ~DefaultCRTLogSystem() override = default;
 
                 DefaultCRTLogSystem(DefaultCRTLogSystem&&) = delete;
                 DefaultCRTLogSystem(const DefaultCRTLogSystem&) = delete;

src/aws-cpp-sdk-core/include/aws/core/utils/logging/DefaultLogSystem.h

@@ -44,7 +44,7 @@ namespace Aws
                  */
                 DefaultLogSystem(LogLevel logLevel, const Aws::String& filenamePrefix);
 
-                virtual ~DefaultLogSystem();
+                virtual ~DefaultLogSystem() override;
 
                 /**
                  * Flushes buffered messages to the file system.

src/aws-cpp-sdk-core/include/aws/core/utils/logging/FormattedLogSystem.h

@@ -29,7 +29,7 @@ namespace Aws
                  * Initializes log system with logLevel
                  */
                 FormattedLogSystem(LogLevel logLevel);
-                virtual ~FormattedLogSystem() = default;
+                virtual ~FormattedLogSystem() override = default;
 
                 /**
                  * Gets the currently configured log level.
@@ -58,7 +58,7 @@ namespace Aws
                 /**
                  * Stops logging on this logger without destroying the object.
                  */
-                virtual void Stop() override { return SetLogLevel(Aws::Utils::Logging::LogLevel::Off); };
+                virtual void Stop() override { return SetLogLevel(Aws::Utils::Logging::LogLevel::Off); }
             protected:
                 /**
                  * This is the method that most logger implementations will want to override.

src/aws-cpp-sdk-core/include/aws/core/utils/logging/LogSystemInterface.h

@@ -51,7 +51,7 @@ namespace Aws
                 /**
                  * Stops logging on this logger without destroying the object.
                  */
-                virtual void Stop() { return; };
+                virtual void Stop() { return; }
             };
 
         } // namespace Logging

src/aws-cpp-sdk-core/include/aws/core/utils/threading/DefaultExecutor.h

@@ -27,7 +27,7 @@ namespace Aws
             {
             public:
                 DefaultExecutor() : m_state(State::Free) {}
-                ~DefaultExecutor();
+                ~DefaultExecutor() override;
 
                 void WaitUntilStopped() override;
             protected:

src/aws-cpp-sdk-core/include/aws/core/utils/threading/Executor.h

@@ -45,7 +45,7 @@ namespace Aws
                 /**
                  * Call to wait until all tasks have finished.
                  */
-                virtual void WaitUntilStopped() { return; };
+                virtual void WaitUntilStopped() { return; }
 
             protected:
                 /**

src/aws-cpp-sdk-core/include/aws/core/utils/threading/PooledThreadExecutor.h

@@ -35,7 +35,7 @@ namespace Aws
             {
             public:
                 PooledThreadExecutor(size_t poolSize, OverflowPolicy overflowPolicy = OverflowPolicy::QUEUE_TASKS_EVENLY_ACROSS_THREADS);
-                ~PooledThreadExecutor();
+                ~PooledThreadExecutor() override;
 
                 /**
                 * Rule of 5 stuff.

src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp

@@ -26,7 +26,7 @@ const char GeneralHTTPCredentialsProvider::AWS_EKS_CONTAINER_HOST[]      = "169.
 const char GeneralHTTPCredentialsProvider::AWS_EKS_CONTAINER_HOST_IPV6[] = "fd00:ec2::23";
 
 
-bool IsAllowedIp(const Aws::String& authority)
+static bool IsAllowedIp(const Aws::String& authority)
 {
     // address is an ECS / EKS container host
     if (authority == GeneralHTTPCredentialsProvider::AWS_ECS_CONTAINER_HOST) // ECS container host

src/aws-cpp-sdk-core/source/auth/signer/AWSAuthEventStreamV4Signer.cpp

@@ -154,7 +154,7 @@ static void WriteBigEndian(Aws::String& str, uint64_t n)
     int shift = 56;
     while(shift >= 0)
     {
-        str.push_back((n >> shift) & 0xFF);
+        str.push_back(static_cast<char>((n >> shift) & 0xFF));
         shift -= 8;
     }
 }

src/aws-cpp-sdk-core/source/client/AWSUrlPresigner.cpp

@@ -29,7 +29,7 @@ Aws::Client::AWSAuthSigner* AWSUrlPresigner::GetSignerByName(const char* name) c
     return m_awsClient.GetSignerByName(name);
 }
 
-std::shared_ptr<Aws::Http::HttpRequest>
+static std::shared_ptr<Aws::Http::HttpRequest>
 ConvertToRequestForPresigning(const Aws::AmazonWebServiceRequest& request,
                               const Aws::Http::URI& uri,
                               Aws::Http::HttpMethod method,
@@ -179,7 +179,7 @@ Aws::String AWSUrlPresigner::GeneratePresignedUrl(const Aws::Endpoint::AWSEndpoi
         }
     }
 
-    return GeneratePresignedUrl(uri, method, signerRegionOverride, signerServiceNameOverride, signerName, customizedHeaders, expirationInSeconds, serviceSpecificParameters);
+    return GeneratePresignedUrl(uri, method, signerRegionOverride, signerServiceNameOverride, signerName, customizedHeaders, static_cast<long long>(expirationInSeconds), serviceSpecificParameters);
 }
 
 Aws::String AWSUrlPresigner::GeneratePresignedUrl(const Aws::AmazonWebServiceRequest& request,