fix warnings #2944
Draft
fix warnings #2944
+199
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ namespace Aws | |||
| AWS_UNREFERENCED_PARAM(AMZN_XML_CONTENT_TYPE); | |||
| } | |||
|
|
|||
| virtual ~AmazonSerializableWebServiceRequest() {} | |||
There was a problem hiding this comment.
nit: space before braces. do we actually need braces in this case at all?
There was a problem hiding this comment.
no, there currently is no consistency with having or not having the empty {}
There was a problem hiding this comment.
should I remove all of them
| @@ -128,6 +128,71 @@ namespace Aws | |||
| return true; | |||
| default: | |||
| return false; | |||
| case HttpResponseCode::REQUEST_NOT_MADE: | |||
There was a problem hiding this comment.
what is the actual warning? id rather not list all enum values if possible
There was a problem hiding this comment.
It looks like this:
warning: 15 enumeration values not explicitly handled in switch: 'AWS_MQTT5_PT_RESERVED', 'AWS_MQTT5_PT_CONNECT', 'AWS_MQTT5_PT_CONNACK'..
SergeyRyabinin
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2363
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.