Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devcontainer): vscode devcontainer configuration #682

Merged
merged 11 commits into from
Jan 25, 2024

Conversation

valter-silva-au
Copy link
Contributor

@valter-silva-au valter-silva-au commented Jan 16, 2024

Add VSCode DevContainer configuration to the project. The goal is to ease development by including a systematic way of consistently having all the dependencies installed and ready. This pull-request achieves a similar goal as described in #603.

Artifacts:

node ➜ /workspaces/aws-pdk (feat/devcontainer) $ devcontainer-info 

Development container image information

- Image version: 1.0.8
- Definition ID: typescript-node
- Variant: 18-bullseye
- Source code repository: https://github.com/devcontainers/images
- Source code release/branch: v0.3.27
- Timestamp: Wed, 10 Jan 2024 19:54:32 GMT

More info: https://github.com/devcontainers/images/tree/main/src/typescript-node/history/1.0.8.md

node ➜ /workspaces/aws-pdk (feat/devcontainer) $ pnpm --version
8.14.0
node ➜ /workspaces/aws-pdk (feat/devcontainer) $ poetry --version
Poetry (version 1.7.1)
node ➜ /workspaces/aws-pdk (feat/devcontainer) $ projen --version
0.79.1
node ➜ /workspaces/aws-pdk (feat/devcontainer) $ java --version
openjdk 11.0.21 2023-10-17 LTS
OpenJDK Runtime Environment Microsoft-8519785 (build 11.0.21+9-LTS)
OpenJDK 64-Bit Server VM Microsoft-8519785 (build 11.0.21+9-LTS, mixed mode)

Reference:

Copy link
Contributor

@agdimech agdimech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution - added some comments.

Copy link
Contributor

@agdimech agdimech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work getting this added, i'm excited to have a play around with it!

In terms of adding this to the Monorepo construct, we can track that in: #603.

@agdimech agdimech merged commit d01935d into aws:mainline Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants