Skip to content

Commit

Permalink
feat(devcontainer): vscode devcontainer configuration (#682)
Browse files Browse the repository at this point in the history
* feat: ignore .pnpm-store directory

* feat(devcontainer): create vscode devcontainer configuration

* chore(gitignore): ignore pnpm-store directory

* feat: remove -o directive

* chore: remove empty lines

* feat: add java, pnpm and poetry as features

---------

Co-authored-by: Adrian Dimech <[email protected]>
  • Loading branch information
valter-silva-au and agdimech authored Jan 25, 2024
1 parent 6ade7de commit d01935d
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 2 deletions.
29 changes: 29 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"name": "Node.js 18 & TypeScript",
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-18-bullseye",
"features": {
"ghcr.io/devcontainers/features/java": {
"installGradle": true,
"installMaven": true,
"version": "11"
},
"ghcr.io/devcontainers-contrib/features/pnpm": {
"version": "latest"
},
"ghcr.io/devcontainers-contrib/features/poetry": {
"version": "latest"
},
"ghcr.io/devcontainers-contrib/features/projen:1": {}
},
"customizations": {
"vscode": {
"extensions": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"GitHub.vscode-github-actions"
]
}
},
"postCreateCommand": "sudo apt update && sudo apt upgrade -y",
"postStartCommand": "sudo apt update"
}
1 change: 1 addition & 0 deletions .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/sh
set -eo pipefail
set -e pipefail

. "$(dirname "$0")/_/husky.sh"

Expand Down
3 changes: 2 additions & 1 deletion projenrc/projects/pdk-monorepo-project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ export class PDKMonorepoProject extends MonorepoTsProject {
".yarn/cache",
".yarn/__virtual__",
".pnp.cjs",
".pnp.loader.cjs"
".pnp.loader.cjs",
".pnpm-store"
);

// add to local `.npmrc` to automatically avoid build hangs if npx is prompting to install a package
Expand Down

0 comments on commit d01935d

Please sign in to comment.