Replace serde deps with minicbor #38
Conversation
| @@ -1,7 +1,7 @@ | |||
| # Copyright 2021 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
|
|
|||
| SRC_PATH = $(dir $(realpath $(lastword $(MAKEFILE_LIST)))) | |||
| HOST_MACHINE = $(shell uname -m) | |||
| HOST_MACHINE = x86_64 | |||
There was a problem hiding this comment.
This old setup won't work on macos arm64 from best I can understand. I needed to make the changes in this file in order to get things working on my local machine. Happy to revert the changes here if they are not desired.
From what I understand, to get reproducible results across docker host platforms, we can pin this to something like x86 and then just make sure to specify the platform when both building and running the docker image.
`serde_cbor` is deprecated. This PR removes `serde_cbor` and its associated dependencies, replacing them with `minicbor`, a library that is currently maintained. This has the added benefit of slimming down the dependency tree, reducing dependency review burden.
petreeftime
force-pushed
the
zeke-remove-serde
branch
from
7d3eebf
to
e748c0e
Compare
|
@petreeftime any updates here? |
|
Last time I tested this, it didn't work for me. I'll take another look. |
@petreeftime can anything be done to move this forward? |
|
I no longer work on this project, so I will not be able to help, but it seems that minicbor_derive only supports encoding and decoding with indexed fields, rather than fields which are named, as the NSM provides, so the unit tests might work since they self generate the data, but the answers from the NSM will not work. As such, serialization and deserialization needs to be done by hand and cannot work otherwise. @meerd @shtaked |
|
IMO, adding some unit tests with actual API responses from NSM would make it easy to discover such issues and prevent backwards incompatibility. |
Issue #, if available:
#19
Description of changes:
serde_cboris deprecated. This PR removesserde_cborand it's associated dependencies, replacing them withminicbor, a library that is currently maintained. This has the added benefit of slimming down the dependency tree, reducing dependency review burden.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.