Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde_cbor crate has been archived #19

Open
raoulstrackx opened this issue Jan 24, 2022 · 7 comments
Open

serde_cbor crate has been archived #19

raoulstrackx opened this issue Jan 24, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@raoulstrackx
Copy link

The serde_cbor crate has been archived. Is there a plan to deal with this?

@petreeftime
Copy link
Contributor

I looked into alternatives some time ago, and ciborium was missing some features and minicbor required significant work. I'll take another look, I see enarx/ciborium#22 was finally closed and there's a new version of ciborium available, but it would mean dropping support for pre-1.56 Rust versions.

@raoulstrackx
Copy link
Author

Thanks for the fast reply @petreeftime! Much appreciated!

@alcioa alcioa added the enhancement New feature or request label Apr 6, 2022
@emostov
Copy link

emostov commented May 18, 2022

@petreeftime any updates here? :)

@vidhatha
Copy link

vidhatha commented Oct 6, 2022

@petreeftime This causes cargo audit to fail.
Any plans on looking into this issue? Thanks in advance.

@petreeftime
Copy link
Contributor

No, not at the moment. https://github.com/enarx/ciborium seems just about as unmaintained as serde_cbor and https://gitlab.com/twittner/minicbor would require some significant changes. The warning is that the project is unmaintained, which is true, but it seems stable and bug free. I am considering forking it or including it as a subcrate to provide additional maintenance when that will be needed, but at this point there is no real benefit to replace it and can be safely ignored in cargo-audit, unless someone feels strongly about replacing it (probably to minicbor, ciborium seems to be pretty much unmaintained) and provides a PR for it.

@emostov
Copy link

emostov commented Oct 10, 2022

No, not at the moment. https://github.com/enarx/ciborium seems just about as unmaintained as serde_cbor and https://gitlab.com/twittner/minicbor would require some significant changes. The warning is that the project is unmaintained, which is true, but it seems stable and bug free. I am considering forking it or including it as a subcrate to provide additional maintenance when that will be needed, but at this point there is no real benefit to replace it and can be safely ignored in cargo-audit, unless someone feels strongly about replacing it (probably to minicbor, ciborium seems to be pretty much unmaintained) and provides a PR for it.

@petreeftime #38 attempts to replace serde_cbor with minicbor.

@vidhatha
Copy link

@petreeftime thanks for the response. Maybe we can look at @emostov attempts to replace serde_cbor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants