Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

get_ou_name_id tries to create OU that already exists #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

o2346
Copy link

@o2346 o2346 commented May 23, 2020

Issue #, if available: N/A

Description of changes:

Hi team

I found an error at get_ou_name_id. It may not be listing existing OUs properly.

According to the error, It unexpectedly assumes like given OU does not exists yet despite that OU actually exists already.
Then it enters OU creation and naturally failes, finally gives up remaining newly created accout without doing anything else.

It happens on organization which already has many OUs.
On an organization which has 16 OUs, your list_organizational_units_for_parent merely gets 8 OUs, but rest of them are ignored.
It does not happen on another organization which has only 4 OUs.

According to list_organizational_units_for_parent,

You should check NextToken after every operation to ensure that you receive all of the results.

But I'm afraid it's been missing on current revision.

Therefore requesting update to handle NextToken properly and ensure complete results.

Thanks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@o2346 o2346 marked this pull request as ready for review May 23, 2020 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant