This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
get_ou_name_id
tries to create OU that already exists
#4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Hi team
I found an error at get_ou_name_id. It may not be listing existing OUs properly.
According to the error, It unexpectedly assumes like given OU does not exists yet despite that OU actually exists already.
Then it enters OU creation and naturally failes, finally gives up remaining newly created accout without doing anything else.
It happens on organization which already has many OUs.
On an organization which has 16 OUs, your list_organizational_units_for_parent merely gets 8 OUs, but rest of them are ignored.
It does not happen on another organization which has only 4 OUs.
According to list_organizational_units_for_parent,
But I'm afraid it's been missing on current revision.
Therefore requesting update to handle NextToken properly and ensure complete results.
Thanks
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.