Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Newly created account is neglected at failure of get_ou_name_id #5

Closed
o2346 opened this issue May 23, 2020 · 1 comment
Closed

Newly created account is neglected at failure of get_ou_name_id #5

o2346 opened this issue May 23, 2020 · 1 comment

Comments

@o2346
Copy link

o2346 commented May 23, 2020

Current implementation exits before completion of its tasks at some kind of exception such as #4.
Here I mean 'tasks' like deleting default VPCs, executing cloudformation with baseline template on the newly created account.

currently:

Create new account
↓
Move account to OU provided
↓
exit on faliure
↓
newly created account was neglected without processing tasks supposed to be done

This is what I'm unhappy because being forced to clean up such half-baked account, no matter why.
I think it would be helpful if such challengings caused by exceptions were minimized as much as possible.

desirable:

get_ou_name_id as provided
↓
(exit if faliure)
↓
Create new account
↓
Move account to the OU provided

In this sequence, There would at least be no half-baked account on failure of get_ou_name_id.

Or else, could it just continue follwing tasks at any rate instead?
(No matter successful or failure for OU, If we could assume the tasks are isolated from what parent currently is)
Since I guess same issue would also occurs at faliure of 'Move account'.

Thanks

@o2346 o2346 changed the title Newly created account were neglected at failure of get_ou_name_id Newly created account is neglected at failure of get_ou_name_id May 23, 2020
@khastation
Copy link
Contributor

khastation commented Apr 20, 2022

@o2346 were you able to fix this issue? If yes, feel free to open a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants