Skip to content

docs(appsync_events): improve AppSync events documentation #6572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #6570

Summary

Changes

This pull request addresses several inconsistencies found in the documentation following the recent release of the AppSync events event handler.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner April 26, 2025 10:05
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 26, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 26, 2025
@leandrodamascena leandrodamascena self-assigned this Apr 26, 2025
@leandrodamascena leandrodamascena removed the request for review from anafalcao April 26, 2025 10:11
@leandrodamascena leandrodamascena linked an issue Apr 26, 2025 that may be closed by this pull request
1 task
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (dfed319) to head (8e598f8).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6572   +/-   ##
========================================
  Coverage    96.11%   96.11%           
========================================
  Files          253      253           
  Lines        12086    12086           
  Branches       898      898           
========================================
  Hits         11617    11617           
  Misses         369      369           
  Partials       100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the CloudFormation template for the AppSync events in the diff

@leandrodamascena
Copy link
Contributor Author

I don't see the CloudFormation template for the AppSync events in the diff

Yep, I forgot to push the commit. Fixed.

@leandrodamascena leandrodamascena merged commit 67ef278 into develop Apr 28, 2025
12 checks passed
@leandrodamascena leandrodamascena deleted the docs/improve-app-events branch April 28, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Improve documentation for AppSync events
2 participants