Skip to content

docs(appsync_events): improve AppSync events documentation #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ran-isenberg
Copy link
Contributor

@ran-isenberg ran-isenberg commented Apr 26, 2025

Issue number: part of #6570

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ran-isenberg ran-isenberg requested a review from a team as a code owner April 26, 2025 14:03
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 26, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2025
@ran-isenberg ran-isenberg changed the title docs: fix wrong highlights for AppSync event handler docs(appsync_events): improve AppSync events documentation Apr 26, 2025
@ran-isenberg
Copy link
Contributor Author

@leandrodamascena FYI.

@dreamorosi
Copy link
Contributor

dreamorosi commented Apr 28, 2025

Is this still needed now that we merged #6572?

@leandrodamascena
Copy link
Contributor

Hi @ran-isenberg! Thank you so much for all the attention on the project as always. As we discussed on Discord, I merged a PR that fixed this so I'm going to close this one.

If you want to send a new PR to add Pydantic Model to this event, why not? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants