feat(appsync-modelgen-plugin): add support for generation route definitions #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundersc
reviewed
Sep 3, 2024
packages/appsync-modelgen-plugin/src/visitors/appsync-model-introspection-visitor.ts
Show resolved
Hide resolved
sundersc
reviewed
Sep 3, 2024
packages/appsync-modelgen-plugin/src/interfaces/introspection/model-schema.ts
Outdated
Show resolved
Hide resolved
sundersc
approved these changes
Sep 3, 2024
8 tasks
palpatim
approved these changes
Sep 4, 2024
| } | ||
| `; | ||
|
|
||
| const generationDirective: Directive = { |
There was a problem hiding this comment.
We should pull this from the directives package?
There was a problem hiding this comment.
Yes, this can be removed once the new version of @aws-amplify/graphql-directives is released.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
generationskey to model introspection schema.@generationdirective) from populating existingquerieskey in MIS; instead assigns them to the newgenerationskey.Codegen Paramaters Changed or Added
N/A
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassesRelevant documentation is changed or added (and PR referenced)Docs PRs are WIPChanges are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modifiedChanges are tested on windows. Some Node functions (such aspath) behave differently on windows.type,input,enum,interface,unionand scalar types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.