feat(conversation): add conversation route handling in mis #872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
conversation
directives for model introspection schema.A note on breaking changes
I've confirmed with the Console team and tested Data Schema myself that this change doesn't break consumers. Unknown keys, such as
conversations
andgenerations
(#869) are ignored by both consumers. However, a consumer of codegen that:@conversation
or@generation
directiveand
@conversation
or@generation
directivewill break because codegen isn't aware of these directives.
For Data Schema, this in unproblematic. Customers won't be able to define conversation or generation routes in their schema without using (transitively) a version of
amplify-graphql-directives
that defines these directives.For Console, this could be problematic for customers that define conversation or generation routes and use data manager in the console. The console team is aware of the impending releases and will work on updating their packages.
Codegen Paramaters Changed or Added
conversations
key within MIS.Issue #, if available
N/A
Description of how you validated changes
Automated snapshot and manual E2E tests.
Checklist
yarn test
passesRelevant documentation is changed or added (and PR referenced)Breaking changes to existing customers are released behind a feature flag or major version updateChanges are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modifiedChanges are tested on windows. Some Node functions (such aspath
) behave differently on windows.type
,input
,enum
,interface
,union
and scalar types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.