Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate pg array objects e2e test in gen2 cdk #2906
chore: migrate pg array objects e2e test in gen2 cdk #2906
Changes from all commits
bbd311d
8439764
5d1456e
55840d7
96e9fd9
a8ecafb
f1f08be
8aeaa60
36bce02
4e3e3df
869e7b8
18e6714
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now or in the next PR: Can we migrate this test to use the configurable stack so we can (eventually) remove the
sql-models
stack? Eventually I'd like us to be using just one stack to reduce the number of test fixtures we have to maintain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts of using an universal
configurable-stack
:json
files, but more time-consuming than have individual CDK per test;AmplifyAuth
construct from individualUserPool
. Plus,AmplifyAuth
provides a convenient way of managingauth
-related resources;AmplifyAuth
based on command files parameters, e.g. when the test is about IAM, then a helper calledcreateIAMIdentityPool
is applied to provision the resource;configurable-stack
, which may lead to redesign of some of the tests' resources provision.I could try to utilize the
configurable-stack
to provision the resources, and figure if OIDC could be supported as well for better management over the test fixtures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your thoughts on this. For now, let's defer any move to configurable-stack, and we can consider a holistic design later.