chore: migrate pg array objects e2e test in gen2 cdk #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Shan <[email protected]>
Signed-off-by: Kevin Shan <[email protected]>
Signed-off-by: Kevin Shan <[email protected]>
|
[Resolved] Running into the same bootstrap issue in CI that blocks the E2E test running. |
Signed-off-by: Kevin Shan <[email protected]>
…ray-objects-e2e-test
Signed-off-by: Kevin Shan <[email protected]>
phani-srikar
previously approved these changes
Oct 1, 2024
palpatim
reviewed
Oct 1, 2024
packages/amplify-graphql-api-construct-tests/src/__tests__/sql-pg-array-objects.test.ts
Show resolved
Hide resolved
| } = options); | ||
| const { projFolderName, connectionConfigName } = options; | ||
|
|
||
| const templatePath = path.resolve(path.join(__dirname, '..', '__tests__', 'backends', 'sql-models')); |
There was a problem hiding this comment.
Now or in the next PR: Can we migrate this test to use the configurable stack so we can (eventually) remove the sql-models stack? Eventually I'd like us to be using just one stack to reduce the number of test fixtures we have to maintain.
There was a problem hiding this comment.
My thoughts of using an universal configurable-stack:
- It's totally feasible to have all tests depends on a single stack with every test defines the specific parameter through various command
jsonfiles, but more time-consuming than have individual CDK per test; - This requires expansion of current configurable stack functionalities, including support of other authorization modes like OIDC, IAM, etc., and the shift to
AmplifyAuthconstruct from individualUserPool. Plus,AmplifyAuthprovides a convenient way of managingauth-related resources; - Another way of supporting different resources requirements of tests is to through more helper functions instead of a centralized provider like
AmplifyAuthbased on command files parameters, e.g. when the test is about IAM, then a helper calledcreateIAMIdentityPoolis applied to provision the resource; - Reducing the number of CDK related files to one stack will benefit maintaining the fixtures, and may need breaking and larger scale changes in current
configurable-stack, which may lead to redesign of some of the tests' resources provision.
I could try to utilize the configurable-stack to provision the resources, and figure if OIDC could be supported as well for better management over the test fixtures.
packages/amplify-graphql-api-construct-tests/src/utils/sql-crudl-helper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Kevin Shan <[email protected]>
Signed-off-by: Kevin Shan <[email protected]>
phani-srikar
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Migrate the Gen1 rds-pg-array-objects E2E test to Gen2 using CDK construct, with pre-provision of resources and generic operations. Plus minor fix/change on resource pre-provision process and CDK init.
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
CI checks and local pre-provision RDS clusters.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.