fix: un-require required input fields with @default #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p5quared
force-pushed
the
default-transformer-unrequire
branch
2 times, most recently
from
0d93765
to
cbc28fd
Compare
| const isPrimaryKeyField = | ||
| field.directives!.find((dir) => dir.name.value === 'primaryKey') || | ||
| (getBaseType(field.type) === 'ID' && field.type.kind === Kind.NON_NULL_TYPE && field.name.value === 'id'); | ||
|
|
There was a problem hiding this comment.
There is one more case to consider here which is when the @default is applied to fields part of a composite primary key. Gen2 doc or this Gen1 doc is more explicit about the schema with composite primary key.
There was a problem hiding this comment.
Added a separate check scanning over sortKeyFields.
8 tasks
The expected behavior here is that "stringValue" should not be required after @default is applied
…n primaryKey fields
…o primary key fields
…omposite key members
…mposite key members
p5quared
force-pushed
the
default-transformer-unrequire
branch
from
2a46b1d
to
e00975f
Compare
|
|
||
| const validateNotCompositeKeyMember = (config: DefaultValueDirectiveConfiguration): void => { | ||
| const objectDirectives = config.object.fields?.flatMap((f) => f.directives); | ||
| const primaryKeyDirective = objectDirectives?.find((dir) => dir?.name.value === 'primaryKey'); |
There was a problem hiding this comment.
nit: can we refactor this check to see if the field is a primary key into it's own method that can be re-used between this method and the one above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Un-require required input fields that have
@defaultapplied. Also update the corresponding snapshot to document this behavior.Prior to this change, a copy of the input object was being modified but
ctx.outputwas not being updated with the new input.CDK / CloudFormation Parameters Changed
n/a
Issue #, if available
aws-amplify/amplify-codegen#390
Description of how you validated changes
Fixed a test snapshot and passed it.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.