Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto increment transformer #2875

Closed
wants to merge 1 commit into from

Conversation

p5quared
Copy link
Contributor

@p5quared p5quared commented Sep 13, 2024

Draft Conditions

This PR is a draft because there are a few things I am aware of and have to modify/finish before it is worthy of formal review:

  • API Name Review: I know that the PR says @generated and the implementation is @sequence. After reaching a consensus I will modify the names as necessary.
    • Update Names: Settled on @default
  • E2E Changes: The E2E tests as they are setup are mostly an exercise and I ran them by disabling validations on the transformer. Mainly I need to rewrite using a mock Postgres datasource.
  • Docs: I wrote documentation in this repo in a place or two but will follow up on places that I may be missing/update docs website as necessary.

Description of changes

Implements a transformer for @generated along with appropriate unit and e2e tests.

CDK / CloudFormation Parameters Changed

N/a

Issue #, if available

#815
(#815 (comment))

Description of how you validated changes

Unit and E2E tests. Also tested with sample app.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

feat: utils detect Postgres datasource

feat: sequence transformer

test: init

chore: init

docs: readme and package.json fix

fix: directive imports

feat: hold this

test: init tests on sequence transformer

test: primitive e2e

chore: various cleanings

chore: cleanup
Copy link
Contributor Author

@p5quared p5quared Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this transformer implementation is nearly identical to the default transformer. It differs in the following ways:

@p5quared p5quared changed the title feat: add @generated transformer feat: add auto increment transformer Sep 13, 2024
@p5quared
Copy link
Contributor Author

Closing as I am going to replace this with a formal PR with the approved API.

@p5quared p5quared closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant