Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking manager upgradability #477

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Staking manager upgradability #477

merged 3 commits into from
Aug 2, 2024

Conversation

minghinmatthewlam
Copy link

@minghinmatthewlam minghinmatthewlam commented Aug 1, 2024 •
edited
Loading

Why this should be merged

Fixes #473

How this works

Calls the parent contract's init functions
makes Warp messenger a constant
Adds Initializable and checks around initializer functions

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2024
View reviewed changes
contracts/staking/StakingManager.sol Dismissed Show dismissed Hide dismissed
@minghinmatthewlam minghinmatthewlam marked this pull request as ready for review August 2, 2024 13:55
@minghinmatthewlam minghinmatthewlam requested a review from a team as a code owner August 2, 2024 13:55
@cam-schultz cam-schultz mentioned this pull request Aug 2, 2024
Merged
@minghinmatthewlam minghinmatthewlam merged commit 30e6eea into staking-contract Aug 2, 2024
12 checks passed
@minghinmatthewlam minghinmatthewlam deleted the staking-upgradability branch August 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam-schultz cam-schultz cam-schultz approved these changes

@iansuvak iansuvak Awaiting requested review from iansuvak iansuvak was automatically assigned from ava-labs/interop

@feuGeneA feuGeneA Awaiting requested review from feuGeneA feuGeneA was automatically assigned from ava-labs/interop

@geoff-vball geoff-vball Awaiting requested review from geoff-vball geoff-vball was automatically assigned from ava-labs/interop

@bernard-avalabs bernard-avalabs Awaiting requested review from bernard-avalabs bernard-avalabs was automatically assigned from ava-labs/interop

@michaelkaplan13 michaelkaplan13 Awaiting requested review from michaelkaplan13 michaelkaplan13 was automatically assigned from ava-labs/interop

Assignees
No one assigned
Labels
L1 Staking Contract upgradeability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minghinmatthewlam @cam-schultz