Staking manager unit tests #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
added this to the Staking Manager MVP - all PRs should target staking-contract branch milestone
cam-schultz
requested review from
minghinmatthewlam,
bernard-avalabs and
michaelkaplan13
|
|
||
| contract NativeTokenStakingManager is StakingManager, INativeTokenStakingManager { | ||
| using Address for address payable; | ||
|
|
||
| constructor(StakingManagerSettings memory settings) { |
There was a problem hiding this comment.
we should avoid pasing through constructor since the contract is meant to be upgradeable
There was a problem hiding this comment.
I'll wait to merge this PR until after #477, and update all the constructor/initialize calls then.
| registrationTimestamp: 1000, | ||
| completionTimestamp: 2000 | ||
| }); | ||
| bytes memory setValidatorWeightPayload = |
There was a problem hiding this comment.
can add a using statement for the IDs
There was a problem hiding this comment.
Are you suggesting adding using for validationID so we can call certain packing methods directly on the validationID? My hesitation there is that not all of the methods take validationID's, and I'd prefer consistent notation.
iansuvak
reviewed
Aug 2, 2024
| * @param uptime The uptime of the validator. | ||
| * @return The packed message. | ||
| */ | ||
| function packValidationUptimeMessage( |
There was a problem hiding this comment.
does abi.encodePacked work for these packs? ref: #482
minghinmatthewlam
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds unit tests for the happy path for validator regestration and delisting.
Adds unit tests for StakingMessages packing/unpacking functions
Adds methods to StakingMessages to achieve full packing/unpacking parity
NativeTokenStakingManager initializes StakingManager
Early return from churn check if max rate is set to 0
Identifies a number of additional test cases that will be implemented later
How this was tested
forge test
How is this documented
N/A