Don't ask about metrics for completion command #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sukantoraymond My commit wasn't GPG signed, I've just amended that commit to sign it, I believe the PR needs to be approved again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1206
The undocumented
completioncommand is used in the installation script in order to output shell completion for the current shell. At that stage, in general, we're in a fresh installation and the user hasn't decided yet about metrics opt-in. In the current version, the command will ask about metrics opt-in making the stepcompletions()of the installation process always fail.This PR fixes this by adding a check using the existing
CheckCommandIsNotCompletionfunction (made public) before deciding that it's time to ask the user about metrics opt-in