Don't ask about metrics for completion command

fix #1206
ava-labs · Dec 9, 2023 · 7f28240 · 7f28240
1 parent 2428aeb
commit 7f28240
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -122,7 +122,7 @@ func createApp(cmd *cobra.Command, _ []string) error {
 	if err := migrations.RunMigrations(app); err != nil {
 		return err
 	}
-	if os.Getenv("RUN_E2E") == "" && !app.Conf.ConfigFileExists() && !utils.FileExists(utils.UserHomePath(constants.OldMetricsConfigFileName)) {
+	if os.Getenv("RUN_E2E") == "" && !app.Conf.ConfigFileExists() && !utils.FileExists(utils.UserHomePath(constants.OldMetricsConfigFileName)) && metrics.CheckCommandIsNotCompletion(cmd) {
 		err = metrics.HandleUserMetricsPreference(app)
 		if err != nil {
 			return err

diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -81,13 +81,13 @@ func userIsOptedIn(app *application.Avalanche) bool {
 
 func HandleTracking(cmd *cobra.Command, app *application.Avalanche, flags map[string]string) {
 	if userIsOptedIn(app) {
-		if !cmd.HasSubCommands() && checkCommandIsNotCompletion(cmd) {
+		if !cmd.HasSubCommands() && CheckCommandIsNotCompletion(cmd) {
 			TrackMetrics(cmd, flags)
 		}
 	}
 }
 
-func checkCommandIsNotCompletion(cmd *cobra.Command) bool {
+func CheckCommandIsNotCompletion(cmd *cobra.Command) bool {
 	result := strings.Fields(cmd.CommandPath())
 	if len(result) >= 2 && result[1] == "completion" {
 		return false