Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

refactor(lanelet2_extension): move RegisterRegulatoryElement to cpp file #222

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 20, 2023

Description

To register a class, put
RegisterRegulatoryElement regMyClass;
somewhere in your cpp file.

Follow this comment to move RegisterRegulatoryElement to cpp file. Also, remove redundant namespace and move the constructor to match the comment about object creation.

Related links

None

Tests performed

Check if lanelet2 map can be loaded using simple planning simulator.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a04b3f) 11.11% compared to head (d7c22bb) 11.11%.
Report is 1 commits behind head on main.

❗ Current head d7c22bb differs from pull request most recent head f7c5d7d. Consider uploading reports for the commit f7c5d7d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   11.11%   11.11%   -0.01%     
==========================================
  Files          37       37              
  Lines        2708     2709       +1     
  Branches     1387     1388       +1     
==========================================
  Hits          301      301              
  Misses       1987     1987              
- Partials      420      421       +1     
Flag Coverage Δ *Carryforward flag
differential 9.46% <ø> (?)
total 11.35% <ø> (+0.24%) ⬆️ Carriedforward from 1ef21e6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isamu-takagi isamu-takagi merged commit ac5ac7d into autowarefoundation:main Jan 18, 2024
12 checks passed
@isamu-takagi isamu-takagi deleted the feat/move-register-regulatory-element branch January 18, 2024 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants