-
Notifications
You must be signed in to change notification settings - Fork 72
feat(lanelet2_extension_python): add python interface/bindings for autoware map and lanelet2_extension package #221
feat(lanelet2_extension_python): add python interface/bindings for autoware map and lanelet2_extension package #221
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=========================================
- Coverage 11.31% 9.87% -1.45%
=========================================
Files 36 39 +3
Lines 2660 3049 +389
Branches 1363 1363
=========================================
Hits 301 301
- Misses 1939 2328 +389
Partials 420 420
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (3/4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (4/4)
19b16a5
to
52e229e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
880dc3a
to
ea14a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
ea14a14
to
2ffa4dd
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
This reverts commit e4e39bd. Signed-off-by: Mamoru Sobue <[email protected]>
…ly. return vector<double> for getClosestCenterPose at cpp Signed-off-by: Mamoru Sobue <[email protected]>
2ffa4dd
to
96b34cf
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
96b34cf
to
8c2315d
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CI for clang-tidy-differential is failing, but since this is coming from extracted Macros from boost.Python, it is difficult fix the code to pass. The build check is passing, and it shouldn't have breaking changes to the functionality so I'm by-passing this check to merge the PR. |
Description
I added lanelet2_extension_python package. It depends on
ros2-lanelet2-python
package.Related links
Tests performed
lanelet2_extension_python/example.py works
Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.