This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
fix ray ground bug #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix! However, this seems to cause some of the tests to fail. Additionally, we require that all commits be signed - please see the details of the DCO check below for more information. Would you mind investigating these two issues? We are also currently past the Pull Request freeze for the 1.15.0 release so this will be scheduled for 1.15.1. |
Signed-off-by: taichiH <[email protected]>
taichiH
force-pushed
the
fix/ray_ground_bug
branch
from
b3524ec
to
f50062a
Compare
|
@JWhitleyWork |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
I fixed the bug related to #24
In line 197, height threshold should be
general_height_thresholdto consider no points hitting on the road.https://github.com/Autoware-AI/core_perception/blob/8abde418d2012d66044547636da982125497015a/points_preprocessor/nodes/ray_ground_filter/ray_ground_filter.cpp#L197