Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_pointcloud_preprocessor): add missing dependencies #9955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wentasah
Copy link

Description

GMP is required in CMakeLists.txt. MPFR is required by GMP and is not installed by default with GMP (Debian GMP package has MPFR dependency only as a suggestion: https://packages.debian.org/sid/libgmp-dev).

Related links

Parent Issue:

  • Link

How was this PR tested?

By building the package with the Nix package manager.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@wentasah wentasah marked this pull request as draft January 17, 2025 22:58
@wentasah wentasah changed the title chore(autoware_pointcloud_preprocessor): Add missing dependencies chore(autoware_pointcloud_preprocessor): add missing dependencies Jan 17, 2025
@wentasah wentasah force-pushed the autoware_pointcloud_preprocessor_deps branch from eed2554 to 0005748 Compare January 17, 2025 22:59
GMP is required in CMakeLists.txt. MPFR is required by GMP not
installed by default with GMP (Debian GMP package has MPFR dependency
only as a suggestion: https://packages.debian.org/sid/libgmp-dev).

Signed-off-by: Michal Sojka <[email protected]>
@wentasah wentasah force-pushed the autoware_pointcloud_preprocessor_deps branch from 0005748 to 49323fa Compare January 17, 2025 22:59
@wentasah wentasah marked this pull request as ready for review January 17, 2025 23:05
@knzo25
Copy link
Contributor

knzo25 commented Jan 20, 2025

@wentasah
Thank you for your contribution !
As I do not directly use that part of the pointcloud preprocessor, I will ask the author of that part

@beginningfan
It seems you added this dependency (#924).
Do you have an opinion about MPFR?
Unless it is actually used, it would just increase the size of the container, etc

@wentasah
Copy link
Author

I forgot to mention that the build fails without any of these added packages. If MPFR is not available, configure fails with:

-- Found GMP: /nix/store/ga9ymzd1mc47z7j5l945j7hld5n4g0a6-gmp-with-cxx-6.3.0/lib/libgmp.so
CMake Error at /nix/store/4k2h9qsps52n1v56zq03yi67dwmxa81i-cmake-3.30.5/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find MPFR (missing: MPFR_LIBRARIES MPFR_INCLUDE_DIR)
Call Stack (most recent call first):
  /nix/store/4k2h9qsps52n1v56zq03yi67dwmxa81i-cmake-3.30.5/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/94a41wjpnccb9v826cghdpjjj63n7j23-cgal-5.6.2/lib/cmake/CGAL/FindMPFR.cmake:54 (find_package_handle_standard_args)
  /nix/store/94a41wjpnccb9v826cghdpjjj63n7j23-cgal-5.6.2/lib/cmake/CGAL/CGAL_SetupGMP.cmake:25 (find_package)
  /nix/store/94a41wjpnccb9v826cghdpjjj63n7j23-cgal-5.6.2/lib/cmake/CGAL/CGAL_SetupCGALDependencies.cmake:37 (include)
  /nix/store/94a41wjpnccb9v826cghdpjjj63n7j23-cgal-5.6.2/lib/cmake/CGAL/CGALConfig.cmake:168 (include)
  CMakeLists.txt:15 (find_package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants