Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce motion_velocity_obstacle_<stop/slow_down/cruise>_module #9807

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 26, 2024

Description

depends on #10035

This PR separates the implementation of obstacle_cruise_planner to the obstacle stop, slow_down, and cruise, and port them to the motion_velocity_planner.

Related links

#10036

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@takayuki5168 takayuki5168 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 26, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from c7368f9 to 56f28be Compare January 9, 2025 11:41
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from e796478 to ea23551 Compare January 19, 2025 14:55
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Jan 27, 2025
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from 6d1ef8b to a41d998 Compare January 28, 2025 13:48
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jan 28, 2025
@takayuki5168 takayuki5168 changed the title Feat/cruise stop slow down modules feat: introduce motion_velocity_obstacle_<stop/slow_down/cruise>_module Jan 28, 2025
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 28, 2025
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from a41d998 to 9f7bae7 Compare January 28, 2025 14:13
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2422 lines in your changes missing coverage. Please review.

Project coverage is 28.43%. Comparing base (461dbc1) to head (304127d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
..._obstacle_stop_module/src/obstacle_stop_module.cpp 0.00% 514 Missing ⚠️
...slow_down_module/src/obstacle_slow_down_module.cpp 0.00% 389 Missing ⚠️
...tacle_cruise_module/src/obstacle_cruise_module.cpp 0.00% 348 Missing ⚠️
...ation_based_planner/optimization_based_planner.cpp 0.00% 348 Missing ⚠️
...module/src/pid_based_planner/pid_based_planner.cpp 0.00% 308 Missing ⚠️
.../optimization_based_planner/velocity_optimizer.cpp 0.00% 176 Missing ⚠️
...n_velocity_obstacle_stop_module/src/parameters.hpp 0.00% 62 Missing ⚠️
...ocity_obstacle_slow_down_module/src/parameters.hpp 0.00% 54 Missing ⚠️
...velocity_obstacle_cruise_module/src/parameters.hpp 0.00% 45 Missing ⚠️
...n_velocity_obstacle_slow_down_module/src/types.hpp 0.00% 40 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9807      +/-   ##
==========================================
- Coverage   29.21%   28.43%   -0.78%     
==========================================
  Files        1439     1473      +34     
  Lines      108115   111075    +2960     
  Branches    42638    43053     +415     
==========================================
  Hits        31588    31588              
- Misses      73485    76445    +2960     
  Partials     3042     3042              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.21% <ø> (ø) Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything appears to run as good as before

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from 91be5fc to c9c491e Compare January 30, 2025 00:09
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/cruise-stop-slow-down-modules branch from c9c491e to 304127d Compare January 30, 2025 00:11
@github-actions github-actions bot removed the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 30, 2025
@takayuki5168 takayuki5168 merged commit 04ed652 into autowarefoundation:main Jan 30, 2025
33 of 34 checks passed
@takayuki5168 takayuki5168 deleted the feat/cruise-stop-slow-down-modules branch January 30, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants