feat(mission_planner): reroute for modified goal #3826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
Signed-off-by: yutaka <[email protected]>
purewater0901
requested review from
isamu-takagi,
kosuke55,
mitsudome-r,
TakaHoribe,
takayuki5168 and
a team
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3826 +/- ##
==========================================
+ Coverage 14.11% 15.06% +0.95%
==========================================
Files 1438 1332 -106
Lines 101526 95069 -6457
Branches 27045 27045
==========================================
- Hits 14328 14326 -2
+ Misses 71513 65057 -6456
- Partials 15685 15686 +1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
reviewed
May 26, 2023
| return; | ||
| } | ||
|
|
||
| if (mrm_route_ && mrm_route_->uuid == msg->uuid) { |
There was a problem hiding this comment.
Suggested change
| if (mrm_route_ && mrm_route_->uuid == msg->uuid) { | |
| if (is_emergency_ && mrm_route_ && mrm_route_->uuid == msg->uuid) { |
?
There was a problem hiding this comment.
maybe it is not needed if alwawy set mrm_route_ when emegency and clear mrm_route when not emegeryc.
kosuke55
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a function to enable rerouting when it receives a modified goal.
Related links
Tests performed
Planning Simulator
Notes for reviewers
Interface changes
No interface changes
Effects on system behavior
No effects
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.