Direct I/O on Linux and macOS #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
shamil-gadelshin
previously approved these changes
Sep 25, 2024
|
Looks like memory allocation also needs to be aligned on Linux, which accidentally is always the case on my machine, but was not the case in CI |
|
User feedback can be found here: https://forum.autonomys.xyz/t/core-utilization-i-o-wait-stats-for-farming-performance/4434?u=nazar-pc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had logic and tests written, so might as well take advantage of it.
Still waiting for feedback from community, but this should reduce bandwidth, memory and even CPU usage a bit since less work is being done. My testing shows non-negligible improvement in disk read bandwidth, but we'll see what others have to say.
Code contributor checklist: