Backport: Direct I/O on Linux and macOS #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Sep 25, 2024
teor2345
reviewed
Sep 25, 2024
There was a problem hiding this comment.
These Linux test failures seem to be blockers:
FAIL [ 0.542s] subspace-farmer disk_piece_cache::tests::basic
FAIL [ 0.686s] subspace-farmer farmer_cache::tests::basic
https://github.com/autonomys/subspace/actions/runs/11035354130/job/30651127398?pr=3065#step:12:1505
The PR looks good overall apart from that.
|
Yes, memory alignment was required, fixed in latest commit |
teor2345
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3064 into Gemini 3h
Code contributor checklist: