This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Core: Lazy MIFs #129
Merged
Core: Lazy MIFs #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error log rebuilding minimal led w/ old build artifacts lying around causes an error: |
mawildoer
reviewed
Nov 12, 2024
| } | ||
|
|
||
| PathData &BFSPath::get_path_data_mut() { | ||
| if (!path_data.unique()) { |
There was a problem hiding this comment.
Deprecated method causing build errors on modern compilers: https://en.cppreference.com/w/cpp/memory/shared_ptr/unique
Obtaining file:///Users/mattwildoer/Projects/faebryk
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... done
Installing backend dependencies ... done
Preparing editable metadata (pyproject.toml) ... error
error: subprocess-exited-with-error
× Preparing editable metadata (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [60 lines of output]
*** scikit-build-core 0.9.2 using CMake 3.27.8 (wheel)
*** Configuring CMake...
2024-11-12 11:24:30,939 - scikit_build_core - WARNING - libdir/ldlibrary: /opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.12/lib/Python.framework/Versions/3.1
2/Python is not a real file! loading initial cache file /private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/tmpdptqu5gm/build/CMakeInit.txt
-- The CXX compiler identification is AppleClang 15.0.0.15000309
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python: /Users/mattwildoer/Projects/faebryk/.venv/bin/python3.12 (found version "3.12.7") found components: Interpreter Development.Module
-- Python_EXECUTABLE: /Users/mattwildoer/Projects/faebryk/.venv/bin/python3.12
-- Python_INCLUDE_DIR: /opt/homebrew/Cellar/[email protected]/3.12.7_1/Frameworks/Python.framework/Versions/3.12/include/python3.12
-- Python_LIBRARY: /opt/homebrew/opt/[email protected]/Frameworks/Python.framework/Versions/3.12/Python
-- Configuring done (14.5s)
-- Generating done (0.0s)
-- Build files have been written to: /private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/tmpdptqu5gm/build
*** Building project with Ninja...
[1/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/bfs.cpp.o
FAILED: CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/bfs.cpp.o
/Library/Developer/CommandLineTools/usr/bin/c++ -DEDITABLE=0 -Dfaebryk_core_cpp_EXPORTS -I/Users/mattwildoer/Projects/faebryk/src/faebryk/core/cpp/include -I/opt/homebrew/Cellar/p
[email protected]/3.12.7_1/Frameworks/Python.framework/Versions/3.12/include/python3.12 -I/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/nanobind/include -O2 -O3 -DNDEBUG -std=gnu++20 -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX15.1.sdk -fPIC -fvisibility=hidden -fno-stack-protector -Os -MD -MT CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/bfs.cpp.o -MF CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/bfs.cpp.o.d -o CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/bfs.cpp.o -c /Users/mattwildoer/Projects/faebryk/src/faebryk/core/cpp/src/pathfinder/bfs.cpp /Users/mattwildoer/Projects/faebryk/src/faebryk/core/cpp/src/pathfinder/bfs.cpp:78:20: error: no member named 'unique' in 'std::shared_ptr<PathData>'
if (!path_data.unique()) {
~~~~~~~~~ ^
1 error generated.
[2/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/pathfinder/pathcounter.cpp.o
[3/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/link.cpp.o
[4/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/path.cpp.o
[5/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/links.cpp.o
[6/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/graphinterfaces.cpp.o
[7/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/graphinterface.cpp.o
[8/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/node.cpp.o
[9/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/graph/graph.cpp.o
[10/24] Building CXX object CMakeFiles/faebryk_core_cpp.dir/src/main.cpp.o
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "/Users/mattwildoer/Projects/faebryk/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
main()
File "/Users/mattwildoer/Projects/faebryk/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/mattwildoer/Projects/faebryk/.venv/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 176, in prepare_metadata_for_build_edi
table whl_basename = build_hook(metadata_directory, config_settings)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/hatchling/build.py", line 83, in build_editable
return os.path.basename(next(builder.build(directory=wheel_directory, versions=['editable'])))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/hatchling/builders/plugin/interface.py", line 147, in
build build_hook.initialize(version, build_data)
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/scikit_build_core/hatch/plugin.py", line 121, in initi
alize self._initialize(build_data=build_data)
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/scikit_build_core/hatch/plugin.py", line 237, in _init
ialize builder.build(build_args=build_args)
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/scikit_build_core/builder/builder.py", line 229, in bu
ild self.config.build(
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/scikit_build_core/cmake.py", line 243, in build
self._build(*local_args, *build_args)
File "/private/var/folders/8v/zd4990r94sj86c3cz5gszwcc0000gn/T/pip-build-env-jorra5vc/overlay/lib/python3.12/site-packages/scikit_build_core/cmake.py", line 254, in _build
raise FailedLiveProcessError(msg) from None
scikit_build_core.errors.FailedLiveProcessError: CMake build failed
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
[notice] A new release of pip is available: 24.2 -> 24.3.1
[notice] To update, run: pip install --upgrade pip
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
mawildoer
reviewed
Nov 12, 2024
| } | ||
|
|
||
| PathData &BFSPath::get_path_data_mut() { | ||
| if (!path_data.use_count() == 1) { |
There was a problem hiding this comment.
See dangers on multithreading for future here: https://en.cppreference.com/w/cpp/memory/shared_ptr/use_count
scripts/find_duplicate_test_files.sh
Outdated
There was a problem hiding this comment.
This is an odd thing to enforce, but we can discuss it another time
src/faebryk/core/cpp/__init__.py
Outdated
| @@ -115,6 +118,7 @@ def compile_and_load(): | |||
| is_pyi=True, | |||
| ) | |||
| ) | |||
| subprocess.check_output(["ruff", "check", "--fix", pyi_out]) | |||
There was a problem hiding this comment.
Making this run_live in case there's error output we're gonna want to see
mawildoer
approved these changes
Nov 12, 2024
… a little imperfect
This was referenced Nov 12, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core: Lazy MIFs
Description
Second iteration of lazy MIFs, running directly on C++ core.
Fixes # (issue)
Checklist
Please read and execute the following:
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct: