Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghaw: bump choffmeister/git-describe-semver from 0.3.11 to 0.4.0 #1276

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps choffmeister/git-describe-semver from 0.3.11 to 0.4.0.

Release notes

Sourced from choffmeister/git-describe-semver's releases.

v0.4.0

Changelog

  • 1235d19 Fix action
  • 92b2c9c Fix readme
  • e1fa986 Improve github action
  • d2b6ec0 Readd next-release support to action (#7)
  • cc4b917 Support git repository checkouts using git worktree (#1) (#5)
  • edfdd5c Update golang 1.21
  • 3862bfb feat: Next release version (#6)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [choffmeister/git-describe-semver](https://github.com/choffmeister/git-describe-semver) from 0.3.11 to 0.4.0.
- [Release notes](https://github.com/choffmeister/git-describe-semver/releases)
- [Changelog](https://github.com/choffmeister/git-describe-semver/blob/main/.goreleaser.yml)
- [Commits](choffmeister/git-describe-semver@v0.3.11...v0.4.0)

---
updated-dependencies:
- dependency-name: choffmeister/git-describe-semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@atc0005
Copy link
Owner

atc0005 commented Dec 15, 2023

This PR is on hold until this bug report can be resolved:

@atc0005
Copy link
Owner

atc0005 commented Jan 12, 2024

No response from the project maintainer(s) yet.

Digging into the changes between v0.3.11 and v0.4.0 the biggest difference (at first glance) that might explain the problem appears to be the change from using the flags standard library package to using the jessevdk/go-flags package.

Local testing replicates the error.

Digging further I find:

and reading the notes from that package's maintainer it is clear that support for explicitly setting a boolean flag value as false will not be provided.

Projects using this tool are not relying on that behavior, but I was relying on the ability to explicitly set a boolean configuration setting for the GitHub Action as false (which no longer works).

Where I'm using the GitHub Action I'll plan to swap to using an explicit Docker container since the GH Action apparently has a different issue (set to use the latest container tag even if you specify an explicit version of the Action to use).

@atc0005 atc0005 closed this Jan 12, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 12, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/master/choffmeister/git-describe-semver-0.4.0 branch January 12, 2024 23:19
@atc0005 atc0005 removed this from the Next Release milestone Jan 12, 2024
atc0005 added a commit that referenced this pull request Jan 12, 2024
Replace the (currently) problematic GitHub Action with a
custom job (`git_describe_semver`) that explicitly uses the
v0.3.11 version of the Docker container to generate the release
asset release version.

That version is captured as the job's `version` output which
is referenced by other jobs in the build-images and
release-build workflows. Those jobs are set as dependent on
the `git_describe_semver` job so that they only run after
the asset release version is computed.

Since the value is computed once at the start of the workflow,
I've updated the `actions/checkout` step for each job to use
the default checkout option(s) instead of pulling the full
repo history each time. This should (somewhat) optimize that
step in the build process.

refs GH-1276
atc0005 added a commit that referenced this pull request Jan 12, 2024
Replace the (currently) problematic GitHub Action with a
custom job (`git_describe_semver`) that explicitly uses the
v0.3.11 version of the Docker container to generate the release
asset release version.

That version is captured as the job's `version` output which
is referenced by other jobs in the build-images and
release-build workflows. Those jobs are set as dependent on
the `git_describe_semver` job so that they only run after
the asset release version is computed.

Since the value is computed once at the start of the workflow,
I've updated the `actions/checkout` step for each job to use
the default checkout option(s) instead of pulling the full
repo history each time. This should (somewhat) optimize that
step in the build process.

refs GH-1276
atc0005 added a commit that referenced this pull request Jan 13, 2024
Replace the (currently) problematic GitHub Action with a
custom job (`git_describe_semver`) that explicitly uses the
v0.3.11 version of the Docker container to generate the release
asset release version.

That version is captured as the job's `version` output which
is referenced by other jobs in the build-images and
release-build workflows. Those jobs are set as dependent on
the `git_describe_semver` job so that they only run after
the asset release version is computed.

Since the value is computed once at the start of the workflow,
I've updated the `actions/checkout` step for each job to use
the default checkout option(s) instead of pulling the full
repo history each time. This should (somewhat) optimize that
step in the build process.

NOTE: Earlier prototype or "scratch" / "testing" jobs and steps
are retained in commented out form for future reference.

refs GH-1276
atc0005 added a commit that referenced this pull request Feb 1, 2024
Replace the (currently) problematic GitHub Action used in the scheduled
monthly image build workflow with a custom job (`git_describe_semver`)
that explicitly uses the v0.3.11 version of the Docker container to
generate the release asset release version.

That version is captured as the job's `version` output which is
referenced by the `build_all_images_using_makefile` job in the
scheduled-monthly workflow. That job is set as dependent on the
`git_describe_semver` job so that they only run after the asset
release version is computed.

Since the value is computed once at the start of the workflow,
I've updated the `actions/checkout` step for the
`build_all_images_using_makefile` job to use the default checkout
option(s) instead of pulling the full repo history each time. This
should (somewhat) optimize that step in the build process.

refs GH-1299
refs GH-1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant