Replace choffmeister/git-describe-semver GH action #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atc0005
force-pushed
the
pr1276-replace-git-describe-semver-gh-action
branch
from
db2d7fb
to
84f1404
Compare
Replace the (currently) problematic GitHub Action with a custom job (`git_describe_semver`) that explicitly uses the v0.3.11 version of the Docker container to generate the release asset release version. That version is captured as the job's `version` output which is referenced by other jobs in the build-images and release-build workflows. Those jobs are set as dependent on the `git_describe_semver` job so that they only run after the asset release version is computed. Since the value is computed once at the start of the workflow, I've updated the `actions/checkout` step for each job to use the default checkout option(s) instead of pulling the full repo history each time. This should (somewhat) optimize that step in the build process. NOTE: Earlier prototype or "scratch" / "testing" jobs and steps are retained in commented out form for future reference. refs GH-1276
atc0005
force-pushed
the
pr1276-replace-git-describe-semver-gh-action
branch
from
eaa464b
to
03ccd45
Compare
atc0005
added a commit
that referenced
this pull request
Feb 1, 2024
Replace the (currently) problematic GitHub Action used in the scheduled monthly image build workflow with a custom job (`git_describe_semver`) that explicitly uses the v0.3.11 version of the Docker container to generate the release asset release version. That version is captured as the job's `version` output which is referenced by the `build_all_images_using_makefile` job in the scheduled-monthly workflow. That job is set as dependent on the `git_describe_semver` job so that they only run after the asset release version is computed. Since the value is computed once at the start of the workflow, I've updated the `actions/checkout` step for the `build_all_images_using_makefile` job to use the default checkout option(s) instead of pulling the full repo history each time. This should (somewhat) optimize that step in the build process. refs GH-1299 refs GH-1276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the (currently) problematic GitHub Action with a custom job (
git_describe_semver) that explicitly uses the v0.3.11 version of the Docker container to generate the release asset release version.That version is captured as the job's
versionoutput which is referenced by other jobs in the build-images and release-build workflows. Those jobs are set as dependent on thegit_describe_semverjob so that they only run after the asset release version is computed.Since the value is computed once at the start of the workflow, I've updated the
actions/checkoutstep for each job to use the default checkout option(s) instead of pulling the full repo history each time. This should (somewhat) optimize that step in the build process.refs GH-1276