Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Rohit as core docs maintainer and Prince as docs triager #3675

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
* @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove inactive maintainer from default owners.

According to the PR objectives, inactive docs maintainers should be removed. Please remove @magicmatatjahu from the default owners list.

-* @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve
+* @derberg @akshatnema @anshgoyalevil @mayaleeeee @asyncapi-bot-eve
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve
* @derberg @akshatnema @anshgoyalevil @mayaleeeee @asyncapi-bot-eve

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg Man! This bot is tracking our activity as well 🤣, AI has become so correct? 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat

yes, adults talking now

Copy link
Member

@magicmatatjahu magicmatatjahu Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actively maintain the code for 2 years, so don't worry, I can be removed :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quetzalliwrites can you please update the PR accordingly, before he changes his mind 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I can do it 😄


# All .md files
*.md @quetzalliwrites @asyncapi-bot-eve
*.md @quetzalliwrites @TRohit20 @asyncapi-bot-eve
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg why does this have errors? XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because committer need maintainer-level rights to be respected by codeowners in the automation - I'll adjust settings once we merge


markdown/blog/*.md @thulieblack @quetzalliwrites
markdown/community/*.md @thulieblack @quetzalliwrites
markdown/blog/*.md @thulieblack @quetzalliwrites @TRohit20
markdown/community/*.md @thulieblack @quetzalliwrites @TRohit20

README.md @quetzalliwrites @derberg @akshatnema @magicmatatjahu @mayaleeeee @asyncapi-bot-eve
#docTriagers: TRohit20 BhaswatiRoy VaishnaviNandakumar J0SAL
#docTriagers: VaishnaviNandakumar Aahil13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add Prince to doc triagers list.

According to the PR objectives, Prince should be added as a docs triager to test his capabilities in this role.

Please update the doc triagers list to include Prince:

-#docTriagers: VaishnaviNandakumar Aahil13
+#docTriagers: VaishnaviNandakumar Aahil13 Prince
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#docTriagers: VaishnaviNandakumar Aahil13
#docTriagers: VaishnaviNandakumar Aahil13 Prince

#codeTriagers: sambhavgupta0705 devilkiller-ag
Loading