docs: add Rohit as core docs maintainer and Prince as docs triager #3675
Conversation
quetzalliwrites
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request updates the Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 180000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -8,11 +8,11 @@ | |||
| * @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve | |||
|
|
|||
| # All .md files | |||
| *.md @quetzalliwrites @asyncapi-bot-eve | |||
| *.md @quetzalliwrites @TRohit20 @asyncapi-bot-eve | |||
There was a problem hiding this comment.
@derberg why does this have errors? XD
There was a problem hiding this comment.
it's because committer need maintainer-level rights to be respected by codeowners in the automation - I'll adjust settings once we merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
CODEOWNERS (3)
11-11: LGTM! Rohit added as core docs maintainer.The change correctly adds @TRohit20 as a core docs maintainer with ownership of all markdown files, aligning with the PR objectives.
13-14: LGTM! Consistent ownership assignments.The changes correctly extend @TRohit20's maintainer role to specific documentation directories, maintaining consistency with the overall ownership structure.
17-17: Verify doc triagers list.The PR objectives mention adding Prince as a docs triager, but this is not reflected in the changes. Please clarify if Prince should be added to the
#docTriagerslist.
CODEOWNERS
Outdated
| @@ -8,11 +8,11 @@ | |||
| * @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve | |||
There was a problem hiding this comment.
Remove inactive maintainer from default owners.
According to the PR objectives, inactive docs maintainers should be removed. Please remove @magicmatatjahu from the default owners list.
-* @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve
+* @derberg @akshatnema @anshgoyalevil @mayaleeeee @asyncapi-bot-eve📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * @derberg @akshatnema @magicmatatjahu @anshgoyalevil @mayaleeeee @asyncapi-bot-eve | |
| * @derberg @akshatnema @anshgoyalevil @mayaleeeee @asyncapi-bot-eve |
There was a problem hiding this comment.
@derberg Man! This bot is tracking our activity as well 🤣, AI has become so correct? 😅
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
Seems like the humans are having a chat
yes, adults talking now
There was a problem hiding this comment.
I don't actively maintain the code for 2 years, so don't worry, I can be removed :)
There was a problem hiding this comment.
@quetzalliwrites can you please update the PR accordingly, before he changes his mind 😄
akshatnema
changed the title
i sure hope so! |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CODEOWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Lighthouse CI
🔇 Additional comments (3)
CODEOWNERS (3)
8-8: LGTM! Inactive maintainer removed as requested.The default owners list has been updated by removing @magicmatatjahu as agreed.
11-11: LGTM! Core docs maintainer added.@TRohit20 has been added as a core docs maintainer for all markdown files, which aligns with the PR objectives.
13-14: LGTM! Core docs maintainer added to specific markdown directories.@TRohit20 has been consistently added as a maintainer for both blog and community markdown files.
| README.md @quetzalliwrites @derberg @akshatnema @magicmatatjahu @mayaleeeee @asyncapi-bot-eve | ||
| #docTriagers: TRohit20 BhaswatiRoy VaishnaviNandakumar J0SAL | ||
| README.md @quetzalliwrites @derberg @akshatnema @magicmatatjahu @mayaleeeee @TRohit20 @asyncapi-bot-eve | ||
| #docTriagers: VaishnaviNandakumar Aahil13 |
There was a problem hiding this comment.
Add Prince to doc triagers list.
According to the PR objectives, Prince should be added as a docs triager to test his capabilities in this role.
Please update the doc triagers list to include Prince:
-#docTriagers: VaishnaviNandakumar Aahil13
+#docTriagers: VaishnaviNandakumar Aahil13 Prince📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #docTriagers: VaishnaviNandakumar Aahil13 | |
| #docTriagers: VaishnaviNandakumar Aahil13 Prince |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
/rtm |
I would like to propose we add Rohit as another docs core maintainer, with the same permission level as mine. (It's time we have more than 1 core docs person!)
I also propose we add Prince testing how he does as a docs triager.
Both folks have confirmed offline they are excited to contribute more :)
p.s. also removing some docs maintainers from file who aren't still active
Summary by CodeRabbit
These improvements enhance our internal workflows and set the stage for smoother future updates without directly impacting your user experience.