Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure #34

Merged
merged 13 commits into from
Oct 9, 2024
91 changes: 44 additions & 47 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,59 +8,56 @@ on:

jobs:

lint:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
fetch-depth: 0 # full history for setuptools_scm

- name: Set up Python
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: 3.9

- name: Run pre-commit
uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1

typing:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
fetch-depth: 0 # full history for setuptools_scm

- name: Set up Python
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: 3.9

- name: Python install
run: |
python -m pip install --upgrade pip
pip install tox

- name: Cache tox environments
id: cache-tox
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
with:
path: .tox
key: tox-typing-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}-${{ hashFiles('tox.ini') }}

- name: Run mypy
run: tox -e typing
# lint:
pllim marked this conversation as resolved.
Show resolved Hide resolved
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
# with:
# fetch-depth: 0 # full history for setuptools_scm

# - name: Set up Python
# uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
# with:
# python-version: 3.12

# - name: Run pre-commit
# uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1

# typing:
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
# with:
# fetch-depth: 0 # full history for setuptools_scm

# - name: Set up Python
# uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
# with:
# python-version: 3.12

# - name: Python install
# run: |
# python -m pip install --upgrade pip
# pip install tox

# - name: Cache tox environments
# id: cache-tox
# uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
# with:
# path: .tox
# key: tox-typing-${{ hashFiles('setup.cfg') }}-${{ hashFiles('pyproject.toml') }}-${{ hashFiles('tox.ini') }}

# - name: Run mypy
# run: tox -e typing

test:
runs-on: ubuntu-latest

strategy:
matrix:
python-version:
- 3.7
- 3.8
- 3.9
python-version: ['3.10', '3.11', '3.12']
jeffjennings marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.1.0
rev: v4.6.0
hooks:
- id: trailing-whitespace
- id: check-toml
Expand All @@ -22,7 +22,7 @@ repos:
hooks:
- id: black

- repo: https://gitlab.com/pycqa/flake8
- repo: https://github.com/PyCQA/flake8
rev: "4.0.1"
hooks:
- id: flake8
2 changes: 1 addition & 1 deletion astropylibrarian/algolia/records.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from urllib.parse import urlparse, urlunparse

from more_itertools import chunked
from pydantic import UUID4, BaseModel, Field, HttpUrl, validator
from pydantic.v1 import UUID4, BaseModel, Field, HttpUrl, validator

if TYPE_CHECKING:
from astropylibrarian.keywords import KeywordDb
Expand Down
2 changes: 1 addition & 1 deletion astropylibrarian/reducers/jupyterbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from typing import TYPE_CHECKING, Any, Dict, Iterator, List, Optional
from urllib.parse import urljoin, urlparse, urlunparse

from pydantic import BaseModel, HttpUrl, validator
from pydantic.v1 import BaseModel, HttpUrl, validator

from astropylibrarian.algolia.records import GuideRecord
from astropylibrarian.reducers.utils import iter_sphinx_sections
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ install_requires =
# Pinning next two to match Algolia docs
# https://www.algolia.com/doc/api-client/advanced/asynchronous-environments/python/language=python
aiohttp>=2.0,<4.0
async_timeout>=<4.0
async_timeout>=4.0.3
PyYAML
pydantic
typer
Expand All @@ -37,7 +37,7 @@ install_requires =
dev =
pytest>=6.1
pytest-doctestplus
types-pkg_resources
types-setuptools
types-PyYAML

[options.entry_points]
Expand Down