-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failure #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelle
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks AMAZING to me! Thanks so much for working on this!
pllim
reviewed
Oct 9, 2024
pllim
reviewed
Oct 9, 2024
pllim
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Otherwise LGTM.
p.s. In the future, please open PRs from your fork. Thanks!
Co-authored-by: P. L. Lim <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests on main are currently failing, and the
setup.cfg
is causing problems for the learn-astropy CI that depends on this package. This PR gets the tests passing and updatessetup.cfg
. Changes:Updates requirements in
setup.cfg
:async_timeout
- based on this algolia .tomltypes-pkg_resources
(deprecated, see here) withtypes-setuptools
Uses
pydantic.v1
throughout code, where previously a couple outlier instances ofpydantic
were used (which was causing multiple problems in tests)Updates python versions for tests
Skips typing and linter CI steps, as there are several (probably benign) typing complaints and the linter step was just force-running pre-commit with a github action that is no longer being updated (
.pre-commit-config.yaml
is still present in the repo). These steps can be uncommented in the workflow .yaml in the future if desired.