Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change non-anchoring links to "anonymous" links. #454

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

delucchi-cmu
Copy link
Contributor

Adding a dunder to the end of the links makes them "anonymous" references, and then we're allowed to have more than one link with the same custom display text.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (fa9f5f3) to head (d6da2c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          47       47           
  Lines        2014     2014           
=======================================
  Hits         1876     1876           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2025

Before [fa9f5f3] After [97917c3] Ratio Benchmark (Parameter)
73.0±0.2ms 73.6±1ms 1.01 benchmarks.MetadataSuite.time_load_partition_info_order7
105±0.4ms 106±0.3ms 1.01 benchmarks.time_test_alignment_even_sky
38.9±0.7ms 39.0±0.6ms 1 benchmarks.Suite.time_pixel_tree_creation
1.04±0.02ms 1.03±0.02ms 1 benchmarks.time_test_cone_filter_multiple_order
73.2±0.2ms 72.8±0.5ms 0.99 benchmarks.MetadataSuite.time_load_partition_join_info
12.2±0.3ms 12.0±0.3ms 0.99 benchmarks.Suite.time_inner_pixel_alignment
350±2ms 347±4ms 0.99 benchmarks.Suite.time_outer_pixel_alignment
18.8±0.1ms 18.5±0.07ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order6

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu merged commit 5be6895 into main Feb 12, 2025
12 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/anon_links branch February 12, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants