Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand margin generation explanation. Use anon references. #485

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

delucchi-cmu
Copy link
Contributor

Expands the description of margin generation:

  • link to LSDB margin demo notebook. gives nice motivation.
  • show the order to mindist lookup table
  • give visual on margin pixels
  • remove text about precise margin filtering, as it has been disabled.

Switches external links to use the dunder anonymous reference style. See also astronomy-commons/hats#454

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (201397c) to head (dc90bd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files          28       28           
  Lines        1811     1811           
=======================================
  Hits         1720     1720           
  Misses         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu requested a review from dougbrn February 7, 2025 20:28
@delucchi-cmu delucchi-cmu merged commit cd17800 into main Feb 7, 2025
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/docs branch February 7, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants