Metric generic angle mapping #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* updated interfaces * metric-generic isotropic angle mapping * updated test values for new sampling methods * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is now an okay way to map local sky angles to coordinate 4-velocity vectors for all supported metrics (bar #52). The reflected flux calculated in the reverberation lags is a little higher than previously, but given that these are abstract units we can rescale as (/if) needed
Here standard is the old sampler, which was lifted from a Younsi et al. (2016) paper (I think) and wasn't every really checked.
The photon paths disagree a little between the two methods:
But agree completely for the flat case (M = eps).
The full reverberation transfer functions calculated differ insignificantly.
Hopefully the doc-string for the method is detailed enough to illustrate how this was done. Generated documentation updates to follow!