Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle mapping API #5

Closed
fjebaker opened this issue Apr 21, 2022 · 1 comment
Closed

Angle mapping API #5

fjebaker opened this issue Apr 21, 2022 · 1 comment
Labels
enhancement New feature or request geometry Relating to a geometrical problem theory Related to mathematical theory

Comments

@fjebaker
Copy link
Member

There already is a function in GradusBase defined for mapping vectors to local sky angles

Gradus.jl/src/GradusBase/geometry.jl

Lines 1 to 3 in 4356a1a

function vector_to_local_sky(m::AbstractMetricParams{T}, u, θ, ϕ) where {T}
error("Not implemented for $(typeof(m))")
end

but this is only implmented for the Kerr case at the moment. We either would need a good way of calculating this in other metrics, else find a reliable way to do parallel transport.
@fjebaker fjebaker added enhancement New feature or request theory Related to mathematical theory geometry Relating to a geometrical problem labels Apr 21, 2022
@fjebaker fjebaker moved this to Todo 🐣 in Gradus.jl Apr 21, 2022
@fjebaker
Copy link
Member Author

fjebaker commented Oct 4, 2022

Done in #54

@fjebaker fjebaker closed this as completed Oct 4, 2022
Repository owner moved this from Todo 🐣 to Done ✅ in Gradus.jl Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request geometry Relating to a geometrical problem theory Related to mathematical theory
Projects
Gradus.jl
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fjebaker