Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update rules_lint #672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update rules_lint #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[[shell]]
indent_style = space
indent_size = 4
2 changes: 1 addition & 1 deletion BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ buildifier(

alias(
name = "format",
actual = "//tools:format",
actual = "//tools/format",
)

bzl_library(
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ bazel_dep(name = "rules_proto", version = "6.0.0")

####### Dev dependencies ########

bazel_dep(name = "aspect_rules_lint", version = "0.9.1", dev_dependency = True)
bazel_dep(name = "aspect_rules_lint", version = "1.0.0-rc8", dev_dependency = True)
bazel_dep(name = "bazel_skylib_gazelle_plugin", version = "1.5.0", dev_dependency = True)
bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)
bazel_dep(name = "gazelle", version = "0.36.0", dev_dependency = True, repo_name = "bazel_gazelle")
Expand Down
8 changes: 0 additions & 8 deletions WORKSPACE.bzlmod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@ load("//.github/workflows:deps.bzl", "aspect_workflows_github_actions_deps")

aspect_workflows_github_actions_deps()

# TODO: rules_lint doesn't have a way to bring deps in under bzlmod
load(
"@aspect_rules_lint//format:repositories.bzl",
"fetch_shfmt",
)

fetch_shfmt()

# Needed for stardoc to compile from Java sources
http_jar(
name = "protobuf-java",
Expand Down
18 changes: 9 additions & 9 deletions e2e/test/3p_deps.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@ teardown() {
workspace --npm-translate-lock
tsconfig

echo 'export * as core from "@nestjs/core"' > source.ts
echo 'console.log("test")' >> source.ts
echo 'export * as core from "@nestjs/core"' >source.ts
echo 'console.log("test")' >>source.ts

ts_project -l -s "source.ts" -d ":node_modules/@types/node" -d ":node_modules/@nestjs/core" -d ":node_modules/@nestjs/common"
ts_project -l -s "source.ts" -d ":node_modules/@types/node" -d ":node_modules/@nestjs/core" -d ":node_modules/@nestjs/common"
run bazel build :foo
assert_success
assert_success
refute_output -p "error" "@nestjs/core" "@types/node"

# upgrade: @nestjs/core from 9.2.0 to 9.2.1
# upgrade: @nestjs/core from 9.2.0 to 9.2.1
# dowgrade: @types/node from 18.11.9 to 18.6.1
run pnpm add @nestjs/[email protected] @types/[email protected] --lockfile-only

run bazel build :foo
assert_failure
assert_output -p "error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type"

# dowgrade: @nestjs/core from 9.2.1 to 9.2.0
# upgrade: @types/node from 18.6.1 to 18.11.9
# dowgrade: @nestjs/core from 9.2.1 to 9.2.0
# upgrade: @types/node from 18.6.1 to 18.11.9
run pnpm add @nestjs/[email protected] @types/[email protected] --lockfile-only

run bazel build :foo
assert_success
assert_success
refute_output -p "error" "@nestjs/core" "@types/node"
}
}
Loading
Loading